Problem/Motivation
Thanks for the module which i hope will make it easier for site admins to manage complaints from folk who have locked themselves out.
I expect I am missing something really simple here but i want to be able to filter the table to only those who are Blocked.
Steps to reproduce
In my set up 2.3.2 when i view the list at admin/people/flood-unblock I see hundreds of rows of data, and no way to find only those that are blocked - or, perhaps Blocked always show at the top - which would make sense, but the screenshot on the project page also does not show Blocked examples so unsure how to confirm. I could click through many pages of results but when i set the Amount filter to eg 200, and then click through, it jumps back to 33 on screen 2.
Proposed resolution
Provide a filter for Blocked v Unblocked
| Comment | File | Size | Author |
|---|---|---|---|
| #6 | interdiff_3-6.txt | 495 bytes | sourabhjain |
| #6 | 3383628-6.patch | 4.22 KB | sourabhjain |
| #3 | flood_control-3383628-3.patch | 4.16 KB | arantxio |
Comments
Comment #2
batigolixComment #3
arantxioHere is a patch that fixes the problem with the filters going back to default state and also added the option to only filter on the blocked request.
Might need some refinement, but at least its a start.
Comment #4
arantxiochanged the status
Comment #5
batigolixI checked this:
- number of rows is saved as it should be, when navigating through various results pages
- labeling of the checkbox can be improved
From:
To:
We dont need to use the words "Filter" and "requests" because it is implied by the context. A small desription can clarify the functionality
Comment #6
sourabhjainWorked on #5. Please review.
Comment #8
batigolixThanks everyone for their efforts.