Problem/Motivation

Thanks for the module which i hope will make it easier for site admins to manage complaints from folk who have locked themselves out.

I expect I am missing something really simple here but i want to be able to filter the table to only those who are Blocked.

Steps to reproduce

In my set up 2.3.2 when i view the list at admin/people/flood-unblock I see hundreds of rows of data, and no way to find only those that are blocked - or, perhaps Blocked always show at the top - which would make sense, but the screenshot on the project page also does not show Blocked examples so unsure how to confirm. I could click through many pages of results but when i set the Amount filter to eg 200, and then click through, it jumps back to 33 on screen 2.

Proposed resolution

Provide a filter for Blocked v Unblocked

Comments

petednz created an issue. See original summary.

batigolix’s picture

Issue tags: +finalist-sprint
arantxio’s picture

StatusFileSize
new4.16 KB

Here is a patch that fixes the problem with the filters going back to default state and also added the option to only filter on the blocked request.

Might need some refinement, but at least its a start.

arantxio’s picture

Status: Active » Needs review

changed the status

batigolix’s picture

Status: Needs review » Needs work

I checked this:

- number of rows is saved as it should be, when navigating through various results pages

- labeling of the checkbox can be improved

From:

'#title' => $this->t('Filter blocked requests.'),

To:

'#title' => $this->t('Only blocked'),
'#description' => $this->t('Show only the blocked requests'),

We dont need to use the words "Filter" and "requests" because it is implied by the context. A small desription can clarify the functionality

sourabhjain’s picture

Status: Needs work » Needs review
StatusFileSize
new4.22 KB
new495 bytes

Worked on #5. Please review.

  • sourabhjain authored 7129287e on 2.3.x
    Issue #3383628 by sourabhjain, Arantxio, batigolix: Filter for only the...
batigolix’s picture

Status: Needs review » Fixed

Thanks everyone for their efforts.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.