Problem/Motivation

2.0.x-dev has a requirement of readmehelp ^1.0

Proposed resolution

Suggest readmehelp rather than require it, as mentioned in the Drupal 10 fixes issue, and allow ^2.0

Issue fork commerce_bulk-3382916

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

derekw created an issue. See original summary.

derekw opened merge request !1

drugan’s picture

drugan commented
Status: Active » Needs work

There is dependency on the readmehelp_converter_service() which should be replaced with similar functionality or applied conditionally.

Also, the dependency in the commerce_bulk.info.yml file should be removed too.

Please, do not forget to manually test your changes on all the actions available.

drugan’s picture

drugan commented

Hi @derekw ,

Have you any progress here?

drugan’s picture

drugan commented
Title: Suggest instead of require ReadmeHelp and add v2 » Remove readmehelp dependency, fix some phpstan and phpcs errors

  • drugan committed 6753c76a on 2.0.x 
    Issue #3382916 by drugan: Remove readmehelp dependency, fix some phpstan...
drugan’s picture

drugan commented
Status: Needs work » Fixed

drugan closed merge request !1

drugan’s picture

drugan commented
Status: Fixed » Closed (fixed)