Problem/Motivation

When there are multiple layout options providers, override for the current active theme doesn't work because the discovery files are sorted alphabetically.
If a theme name starts with "A" and the parent theme starts with "U" like UI Suite Bootstrap, layout options apply from the later one.

Steps to reproduce

1. Create a theme with name "a_theme" and make its base theme "UI Suite Bootstrap"
2. Create "a_theme.layout_options.yml" and override any of the option like "with_container", set "title" to something else.
3. Open Layout Builder to see the override.
4. Override is not applied.

Proposed resolution

Reorder layout options after discovery to put the active theme to the end to have the top priority.

Remaining tasks

No

User interface changes

No

API changes

No

Data model changes

No

CommentFileSizeAuthor
#6 3382858-active-theme-6.patch2.88 KBlexbritvin
Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

lexbritvin created an issue. See original summary.

lexbritvin’s picture

Status: Active » Needs review
grimreaper’s picture

Assigned: Unassigned » grimreaper
grimreaper’s picture

So I made the refactoring and when writing the test I realised that the test was passing even without changes...

So I guess I am missing something to reproduce the bug.

lexbritvin’s picture

StatusFileSize
new2.88 KB

grimreaper’s picture

Assigned: grimreaper » Unassigned
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.