Problem/Motivation

Instead of 'access administration pages' we should use 'administer site configuration' permission for bs_lib.settings route.

CommentFileSizeAuthor
#2 3382477-change-permission-2.patch358 bytespivica

Comments

pivica created an issue. See original summary.

pivica’s picture

Status: Active » Needs review
StatusFileSize
new358 bytes

Here is a patch.

elber’s picture

Status: Needs review » Reviewed & tested by the community

Hi I agree with your idea it makes sense.

Patch is cleanly.

Moving to RTBC.

pivica’s picture

Thx @elber. I am curious, are you using bs_lib or bs_base projects for some of your projects?

  • pivica committed 0c88bbe1 on 8.x-1.x
    Issue #3382477 by pivica: Use 'administer site configuration' permission
    
pivica’s picture

Status: Reviewed & tested by the community » Fixed

Committed.

elber’s picture

Hi I just saw this issue and then I tried to understand how this module works to try help you with a review.

pivica’s picture

> Hi I just saw this issue and then I tried to understand how this module works to try help you with a review.

That does not sounds very helpful ;)

@elber I am not sure how you use Drupal in daily life, but you would look into bs_lib or related bs_base contrib theme only if you are doing a LOT of custom theme development, want to improve and optimize your theme development workflow and want to base your custom themes on Bootstrap framework (currently supported ver 4).

bs_base is quite powerful and a complex theme, but I am maintaining good documentation about it on https://www.drupal.org/docs/contributed-themes/bs-base.

Granted bs_lib is doing a bit more stuff and not just supporting bs_base contrib theme, no special documentation about this, but main use cases are explained on project page https://www.drupal.org/project/bs_lib.

I can not suggest you just randomly pick some issue from bs_base or bs_lib, the stuff is a bit complex and you would first need to use this module and theme a bit before diving into issues.

If you have any more questions, happy to answer.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.