Problem/Motivation

Starterkit theme is missing the changes added to other themes in #3090187: Mechanism to disable preprocessing of base fields in comment entity type so they can be configured via the field UI. Comments will display incorrectly for sites configuring the display of comment base fields in the UI.

Steps to reproduce

Proposed resolution

Change the comment template

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

CommentFileSizeAuthor
#5 starterkit-comment-display.3381877-interdiff-2-5.txt8.09 KBadamps
#5 starterkit-comment-display.3381877-5.patch9.38 KBadamps
#2 starterkit-comment-display.3381877-2.patch1.44 KBadamps

Comments

AdamPS created an issue. See original summary.

adamps’s picture

adamps commented
Status: Active » Needs review
StatusFileSize
new starterkit-comment-display.3381877-2.patch1.44 KB
adamps’s picture

adamps commented
Parent issue: » #2353867: [META] Expose Title and other base fields in Manage Display
smustgrave’s picture

smustgrave commented
Status: Needs review » Needs work

Seems olivero is missing the change too. And didn't see in the parent issue mention if that should be excluded.

adamps’s picture

adamps commented
Status: Needs work » Needs review
StatusFileSize
new starterkit-comment-display.3381877-5.patch9.38 KB
new starterkit-comment-display.3381877-interdiff-2-5.txt8.09 KB

Thanks well spotted. Also the comments in both need updating.

smustgrave’s picture

smustgrave commented
Status: Needs review » Reviewed & tested by the community
Issue tags: +Needs Review Queue Initiative

Thanks for addressing that so quickly!

Think this is ready for committer review.

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 5: starterkit-comment-display.3381877-5.patch, failed testing. View results

adamps’s picture

adamps commented
Status: Needs work » Reviewed & tested by the community

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 5: starterkit-comment-display.3381877-5.patch, failed testing. View results

adamps’s picture

adamps commented
Status: Needs work » Reviewed & tested by the community

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 5: starterkit-comment-display.3381877-5.patch, failed testing. View results

adamps’s picture

adamps commented
Status: Needs work » Reviewed & tested by the community

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 5: starterkit-comment-display.3381877-5.patch, failed testing. View results

viren18febs’s picture

viren18febs commented
Status: Needs work » Reviewed & tested by the community

  • lauriii committed 54e5f9e7 on 11.x 
    Issue #3381877 by AdamPS, smustgrave, viren18febS: Wrong comment display...

  • lauriii committed dc84da68 on 10.2.x 
    Issue #3381877 by AdamPS, smustgrave, viren18febS: Wrong comment display...

  • lauriii committed d73384c9 on 10.1.x 
    Issue #3381877 by AdamPS, smustgrave, viren18febS: Wrong comment display...
lauriii’s picture

lauriii
he/him
Primary language Finnish
Location Finland
commented
Version: 11.x-dev » 10.1.x-dev
Status: Reviewed & tested by the community » Fixed

Committed 54e5f9e and pushed to 11.x. Also cherry-picked to 10.2.x and 10.1.x. Thanks!

adamps’s picture

adamps commented

Great thanks

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.