Problem/Motivation

We recently deployed beta 5.0.0-beta1 to production and have noticed several instances of this error in our logs on one site:

Object of class DateTimeImmutable could not be converted to int in lockr_requirements line 99 of locker.install

Steps to reproduce

Visit the status report at /admin/reports/status

CommentFileSizeAuthor
#7 3378650-object_of_class_datetimeimmutable.patch2.18 KBiggy_lakic

Issue fork lockr-3378650

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

nicrodgers created an issue. See original summary.

nicrodgers’s picture

nicrodgers
Primary language English
Location Monmouthshire, UK
commented
Issue summary: View changes

nicrodgers opened merge request !12

nicrodgers’s picture

nicrodgers
Primary language English
Location Monmouthshire, UK
commented
Assigned: nicrodgers » Unassigned
Status: Active » Needs review
nitesh624’s picture

nitesh624
he/him
Primary language English
Location Ranchi, India
commented
Status: Needs review » Reviewed & tested by the community

Above Merge Request solve the warning related to hook_requirements on status page

Iggy_Lakic made their first commit to this issue’s fork.

iggy_lakic’s picture

iggy_lakic commented
StatusFileSize
new 3378650-object_of_class_datetimeimmutable.patch2.18 KB

This fix seems fine, and I also added similar logic to another place inside module, in `LockrAdminController.php`.
I created a patch for this.

nicrodgers’s picture

nicrodgers
Primary language English
Location Monmouthshire, UK
commented
Status: Reviewed & tested by the community » Needs review

Setting back to NR due to #7.

@Iggy i'm confused why you've made a commit to the fork but then uploaded a patch? I can't see any commits from you in the MR. Do you have more changes to push?

iggy_lakic’s picture

iggy_lakic commented

@nicrodgers sorry for that. Yes, I've made changes inside the LockrAdminController.php where we have similar situation like in lockr.install.

Iggy_Lakic opened merge request !17

phjou’s picture

phjou
he/him
Location Vancouver 🇨🇦 🇪🇺
commented

Merge request is fixing the issue, thanks!

cellar door’s picture

cellar door commented
Status: Needs review » Fixed

Thanks all for this, merged into 5.x and we'll cut an official 5.0 release later today!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.