Problem/Motivation

  • Create a new BDD scenario which the action is to press Login and Grant Button for SPA.
  • Additionally, resolve issues caused by creating a new BDD scenario.

Issue fork cloud-3376363

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

asai.noriaki created an issue. See original summary.

asai.noriaki opened merge request !1902

asai.noriaki’s picture

asai.noriaki commented
Status: Active » Needs review

@yas

Please review it. Thanks.

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Needs review » Needs work

@asai.noriaki

Thank for adding the test scenarios. Can you please change the file name as follows? Thanks

BEFORE:

  • OpenStack-ATDD-01-04-CheckSPAConfigurations.feature
  • OpenStack-ATDD-01-05-OperateSPALogin.feature

AFTER:

  • OpenStack-ATDD-01-04-CheckSpaConfigurations.feature
  • OpenStack-ATDD-01-05-OperateSpaLogin.feature
asai.noriaki’s picture

asai.noriaki commented
Status: Needs work » Needs review

@yas
I renamed files OpenStack-ATDD-01-04 OpenStack-ATDD-01-05.
Please review it. Thanks.

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Title: Create a BDD scenario that press Login and Grant Button for SPA » Add BDD scenario to test clicking on the Login and Grant buttons in SPA
Status: Needs review » Reviewed & tested by the community

@asai.noriaki

Thank you for the update. It looks good. I'll merge the patch to 5.x and 6.x, and close this issue as Fixed.

  • yas committed 0fe809d3 on 6.x authored by asai.noriaki 
    Issue #3376363 by asai.noriaki, yas: Add BDD scenario to test clicking...

  • yas committed 11644632 on 5.x authored by asai.noriaki 
    Issue #3376363 by asai.noriaki, yas: Add BDD scenario to test clicking...
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.