Problem/Motivation

Cannot run example migration in Php 8. 

ddev drush ms --group=migration_tools_example
PHP Fatal error: Declaration of Drupal\migration_tools\Plugin\migrate_plus\data_parser\Dom::openSourceUrl($url) must be compatible with Drupal\migrate_plus\DataParserPluginBase::openSourceUrl(string $url): bool in /var/www/html/docroot/modules/contrib/migration_tools/src/Plugin/migrate_plus/data_parser/Dom.php on line 93

Steps to reproduce

* enable example module
* run above code
* confirm error

Proposed resolution

* Add return type to DOM class

Remaining tasks

User interface changes

API changes

Data model changes

Issue fork migration_tools-3376087

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

robpowell created an issue. See original summary.

robpowell opened merge request !7

paranojik’s picture

paranojik commented
Status: Active » Reviewed & tested by the community

Looks good!

swirt made their first commit to this issue’s fork.

  • swirt committed 868cad9c on 8.x-2.x authored by robpowell 
    Issue #3376087: openSourceUrl($url) must be compatible
swirt’s picture

swirt
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Fixed

Thank you both for this contribution.

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

swirt’s picture

swirt
he/him
Primary language English
commented

Released in #3583136: migration_tools 8.x-2.10

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.