Problem/Motivation

The AddForm.php file contains a global call to the messenger service. Codesniffer throws an error for this.

Steps to reproduce

Run the phpcs command on the module.

Proposed resolution

Inject the messenger service into the AddForm.php file.

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#2 3374376-2.patch1.29 KBsidharth_soman

Issue fork custom_meta-3374376

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

sidharth_soman created an issue. See original summary.

sidharth_soman’s picture

sidharth_soman commented
Assigned: sidharth_soman » Unassigned
Status: Needs work » Needs review
StatusFileSize
new 3374376-2.patch1.29 KB

I have added the DI. Please review this patch

Status: Needs review » Needs work

The last submitted patch, 2: 3374376-2.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

naveenvalecha made their first commit to this issue’s fork.

naveenvalecha’s picture

naveenvalecha
He/Him
commented
Status: Needs work » Needs review

naveenvalecha opened merge request !6

naveenvalecha’s picture

naveenvalecha
He/Him
commented
Title: Requirement of Dependency Injection in the AddForm.php file » Fix Automated tests
naveenvalecha’s picture

naveenvalecha
He/Him
commented
Issue tags: -Dependency Injection (DI) +Novice
naveenvalecha’s picture

naveenvalecha
He/Him
commented
Status: Needs review » Needs work
naveenvalecha’s picture

naveenvalecha
He/Him
commented
Status: Needs work » Needs review
Issue tags: -Novice

  • naveenvalecha committed 9236d28d on 2.0.x 
    Issue #3374376 by naveenvalecha, sidharth_soman: Fix Automated tests

  • naveenvalecha committed 03487658 on 2.1.x 
    Issue #3374376 by naveenvalecha, sidharth_soman: Fix Automated tests

naveenvalecha closed merge request !6

naveenvalecha’s picture

naveenvalecha
He/Him
commented
Status: Needs review » Fixed

I have pushed the change to 2.0.x and cherry-picked it to 2.1.x

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.