Problem/Motivation
FILE: /var/www/html/vb/d_cont/seb/README.md
------------------------------------------------------------------------
FOUND 1 ERROR AND 7 WARNINGS AFFECTING 8 LINES
------------------------------------------------------------------------
3 | WARNING | [ ] Line exceeds 80 characters; contains 151 characters
5 | WARNING | [ ] Line exceeds 80 characters; contains 89 characters
7 | WARNING | [ ] Line exceeds 80 characters; contains 96 characters
12 | WARNING | [ ] Line exceeds 80 characters; contains 112 characters
14 | WARNING | [ ] Line exceeds 80 characters; contains 133 characters
18 | WARNING | [ ] Line exceeds 80 characters; contains 142 characters
22 | WARNING | [ ] Line exceeds 80 characters; contains 120 characters
28 | ERROR | [x] Expected 1 newline at end of file; 0 found
------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------
FILE: /var/www/html/vb/d_cont/seb/src/Plugin/Derivative/EntityBlock.php
----------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
----------------------------------------------------------------------------------------------------------------
83 | WARNING | [x] 'TODO: Add proper config dependencies.' should match the format '@todo Fix problem X here.'
----------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------------------------------------------------
FILE: /var/www/html/vb/d_cont/seb/seb.info.yml
----------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------
4 | ERROR | [x] Expected 1 newline at end of file; 0 found
----------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------
Time: 148ms; Memory: 12MB
Steps to reproduce
Execute the command: phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig seb/
Remaining tasks
Patch review
| Comment | File | Size | Author |
|---|---|---|---|
| #6 | Screenshot from 2023-09-28 10-53-08.png | 90.13 KB | aayushmankotia |
| #4 | Seb_patch.png | 79.31 KB | sakthi_dev |
| #2 | coding-standard-fixed-3372227-2.patch | 3.96 KB | satish_kumar |
| coding-standard-fixes.patch | 3.08 KB | urvashi_vora |
Issue fork seb-3372227
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
Comments
Comment #2
satish_kumar commentedHii, @urvashi_vora
These are the steps I followed:
1. Took clone from git version 1.0.x in drupal 10.1.x
2. Ran this command:
./vendor/bin/phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig modules/contrib/seb/
3. Applied your patch and, again ran phpcs command
found errors.
4. Fixed the errors and provide the patch.
Please Review.
Comment #3
clarkssquared commentedHi Satish_kumar,
I tried to apply your patch using git apply -v but the patch skips and fails to apply, please look at the result in my terminal below:
I then used the patch -p1 approach and the patch was applied except for seb.info.yml because it's been rejected
I then tried to execute the PHPCS command but there are still many PHPCS issues being flagged, for your reference, below are the issues being flagged:
Comment #4
sakthi_dev commentedHi @clarkssquared, I tried to apply the #2 patch and it applied successfully and no issues lists for phpcs. After one more review we can move to RTBC, Attaching the screenshot.
Comment #5
aayushmankotia commentedComment #6
aayushmankotia commentedHi,

The #2 patch was successfully applied with no remaining issues listed for phpcs. Please refer to the attached screenshot for your reference and verification.
Moving to RTBC .
Thanks.
Comment #10
syammohanmp commented