Problem/Motivation

The g2.initial route used to only accept ASCII letters, decimal digits, and space, dash and underscore are valid initials. This has been extended to a non-english-centric view, using Unicode letter and number classes. However, the alphabar throws exceptions when these are included.

Steps to reproduce

  • Define a G2 entry like "été"
  • Add é to the alphabar
  • Navigate to /g2
  • Observe the exception

Proposed resolution

The underlying issue is core bug #3369925: Support Unicode regular expressions in routes, from Symfony 4.3: the URL generator does not match requirements using full Unicode matching.

Remaining tasks

Get a fix in core for the bug.

Until then, keep using the restricted legacy regexp, and avoid starting entries with non-ASCII numbers and letters.

User interface changes

None.

API changes

None.

Data model changes

None.

Comments

fgm created an issue. See original summary.

fgm’s picture

Status: Active » Needs review
StatusFileSize
new0 bytes

Added workaround until core issue is addressed.

fgm’s picture

StatusFileSize
new17.88 KB

Grmph, empty patch.

Status: Needs review » Needs work

The last submitted patch, 3: 3369926-3.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

fgm’s picture

Status: Needs work » Needs review
StatusFileSize
new17.88 KB

Schema typo.

Status: Needs review » Needs work

The last submitted patch, 5: 3369926-5.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

fgm’s picture

Status: Needs work » Needs review
StatusFileSize
new17.89 KB

So that's why it exported as 0/1 instead of true/false.

  • fgm committed baa57f54 on 8.x-1.x
    Issue #3369926 by fgm: work around core routing bug.
    
fgm’s picture

Status: Needs review » Fixed

Merged to current dev HEAD.

fgm’s picture

Status: Fixed » Needs review
StatusFileSize
new4.19 KB

Some DCS fixes. Wonder why I don't get them locally.

fgm’s picture

StatusFileSize
new7.18 KB

Should have caught them all.

fgm’s picture

StatusFileSize
new10.56 KB

No, seriously, WTF phpdoc ?

fgm’s picture

StatusFileSize
new10.56 KB

OK, that one was mine.

fgm’s picture

Status: Needs review » Fixed

No remaining CS issue. Fixed.

  • fgm committed 8d145519 on 8.x-1.x
    Issue #3369926 by fgm: some DCS fixes too.
    

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.