Problem/Motivation

Provide a global solution to the current styling issues:

  • [3363958] Facade for the iframe is not created properly
  • [3361926] Styles are not applied correctly

Proposed solution

  • Rename css/youtube-cookies-popup.css to css/youtube-cookies-layout.css
  • User CSS properties (variables) to make it easy for third parties to change the theme.
  • Provide the HTML structures to the JS rather than constructing them in the JS.
  • Provide smarter CSS classes and more descriptive

Issue fork youtube_cookies-3367484

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

frouco created an issue. See original summary.

frouco opened merge request !23

frouco’s picture

frouco commented
Assigned: frouco » Unassigned
Status: Active » Reviewed & tested by the community

Ready to review

  • frouco committed 8f2051e8 on 2.0.x 
    Issue #3367484: Refactor theming to provide a default styles
frouco’s picture

frouco commented
Status: Reviewed & tested by the community » Fixed
frouco’s picture

frouco commented
Category: Feature request » Task

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.