Problem/Motivation

Near the end of #1149078: States API doesn't work with multiple select fields, we tried to get JavascriptStatesTest::doMultipleSelectTriggerTests() to not just verify that changing the trigger gets the desired results, but also if you restore the trigger to the initial state, all the elements should go back to the initial state, too. Sadly, there seems to be some weirdness in the intersection between item FormAPI elements, isVisible(), chromedriver, and perhaps $trigger->setValue([]) which is causing some of the assertions to fail. However, manually inspecting the test HTML output, and manual testing, both indicate that the states code is really working. Since #1149078 is a 12 year old bug, it'd be sad to hold up committing the fix even longer while sorting out the "perfect" tests. Hence, this follow-up.

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

Issue fork drupal-3367310

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

dww created an issue. See original summary.

nod_ made their first commit to this issue’s fork.

nod_’s picture

Status: Active » Needs review
smustgrave’s picture

Status: Needs review » Needs work

Seems to still be failing :(

Version: 11.x-dev » main

Drupal core is now using the main branch as the primary development branch. New developments and disruptive changes should now be targeted to the main branch.

Read more in the announcement.