Form error when no group admin role is automatically created. [#3364226]

Problem/Motivation

When creating a new 2.x group type, if an admin role isn't automatically created, the following error appears when editing the group type.

  Warning: Undefined array key "creator_roles" in Drupal\group\Entity\Form\GroupTypeForm->form() (line 241 of modules/contrib/group/src/Entity/Form/GroupTypeForm.php).
Drupal\group\Entity\Form\GroupTypeForm->form(Array, Object) (Line: 106)
Drupal\Core\Entity\EntityForm->buildForm(Array, Object)
call_user_func_array(Array, Array) (Line: 536)
Drupal\Core\Form\FormBuilder->retrieveForm('group_type_edit_form', Object) (Line: 283)
Drupal\Core\Form\FormBuilder->buildForm(Object, Object) (Line: 73)
Drupal\Core\Controller\FormController->getContentResult(Object, Object) (Line: 39)
Drupal\layout_builder\Controller\LayoutBuilderHtmlEntityFormController->getContentResult(Object, Object)
call_user_func_array(Array, Array) (Line: 123)
Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->Drupal\Core\EventSubscriber\{closure}() (Line: 580)
Drupal\Core\Render\Renderer->executeInRenderContext(Object, Object) (Line: 124)
Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->wrapControllerExecutionInRenderContext(Array, Array) (Line: 97)
Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->Drupal\Core\EventSubscriber\{closure}() (Line: 169)
Symfony\Component\HttpKernel\HttpKernel->handleRaw(Object, 1) (Line: 81)
Symfony\Component\HttpKernel\HttpKernel->handle(Object, 1, 1) (Line: 58)
Drupal\Core\StackMiddleware\Session->handle(Object, 1, 1) (Line: 48)
Drupal\Core\StackMiddleware\KernelPreHandle->handle(Object, 1, 1) (Line: 106)
Drupal\page_cache\StackMiddleware\PageCache->pass(Object, 1, 1) (Line: 85)
Drupal\page_cache\StackMiddleware\PageCache->handle(Object, 1, 1) (Line: 270)
Drupal\shield\ShieldMiddleware->bypass(Object, 1, 1) (Line: 137)
Drupal\shield\ShieldMiddleware->handle(Object, 1, 1) (Line: 48)
Drupal\Core\StackMiddleware\ReverseProxyMiddleware->handle(Object, 1, 1) (Line: 51)
Drupal\Core\StackMiddleware\NegotiationMiddleware->handle(Object, 1, 1) (Line: 23)
Stack\StackedHttpKernel->handle(Object, 1, 1) (Line: 718)
Drupal\Core\DrupalKernel->handle(Object) (Line: 19)
Warning: Undefined array key "#description" in Drupal\group\Entity\Form\GroupTypeForm->form() (line 241 of modules/contrib/group/src/Entity/Form/GroupTypeForm.php).
Drupal\group\Entity\Form\GroupTypeForm->form(Array, Object) (Line: 106)
Drupal\Core\Entity\EntityForm->buildForm(Array, Object)
call_user_func_array(Array, Array) (Line: 536)
Drupal\Core\Form\FormBuilder->retrieveForm('group_type_edit_form', Object) (Line: 283)
Drupal\Core\Form\FormBuilder->buildForm(Object, Object) (Line: 73)
Drupal\Core\Controller\FormController->getContentResult(Object, Object) (Line: 39)
Drupal\layout_builder\Controller\LayoutBuilderHtmlEntityFormController->getContentResult(Object, Object)
call_user_func_array(Array, Array) (Line: 123)
Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->Drupal\Core\EventSubscriber\{closure}() (Line: 580)
Drupal\Core\Render\Renderer->executeInRenderContext(Object, Object) (Line: 124)
Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->wrapControllerExecutionInRenderContext(Array, Array) (Line: 97)
Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->Drupal\Core\EventSubscriber\{closure}() (Line: 169)
Symfony\Component\HttpKernel\HttpKernel->handleRaw(Object, 1) (Line: 81)
Symfony\Component\HttpKernel\HttpKernel->handle(Object, 1, 1) (Line: 58)
Drupal\Core\StackMiddleware\Session->handle(Object, 1, 1) (Line: 48)
Drupal\Core\StackMiddleware\KernelPreHandle->handle(Object, 1, 1) (Line: 106)
Drupal\page_cache\StackMiddleware\PageCache->pass(Object, 1, 1) (Line: 85)
Drupal\page_cache\StackMiddleware\PageCache->handle(Object, 1, 1) (Line: 270)
Drupal\shield\ShieldMiddleware->bypass(Object, 1, 1) (Line: 137)
Drupal\shield\ShieldMiddleware->handle(Object, 1, 1) (Line: 48)
Drupal\Core\StackMiddleware\ReverseProxyMiddleware->handle(Object, 1, 1) (Line: 51)
Drupal\Core\StackMiddleware\NegotiationMiddleware->handle(Object, 1, 1) (Line: 23)
Stack\StackedHttpKernel->handle(Object, 1, 1) (Line: 718)
Drupal\Core\DrupalKernel->handle(Object) (Line: 19)

Steps to reproduce

Create a new group type by navigating to /admin/group/types/add
Under "Access settings" make sure the "Automatically configure useful default roles" and "Automatically configure an administrative role" options are unchecked.
Click the "Save group type" button to save the new group type.
Navigate to the edit form of the newly created group type. Example: /admin/group/types/manage/test
The error message should display.

Proposed resolution

Error should not display.

Remaining tasks

N/A

User interface changes

N/A

API changes

N/A

Data model changes

N/A

Comment	File	Size	Author
#12	group-form-error-3364226-12.patch	807 bytes	gwvoigt
#4	group-form-error-3364226-0.patch	893 bytes	gwvoigt
#3	SS-Not-reproducable.png	254.2 KB	sahil.goyal
	Screenshot 2023-06-01 at 11.36.58 AM.png	285.21 KB	pcate

Issue fork group-3364226

Show commands

Start within a Git clone of the project using the version control instructions.

Add & fetch this issue fork’s repository

Or, if you do not have SSH keys set up on git.drupalcode.org:

Add & fetch this issue fork’s repository

3364226-form-error-when changes, plain diff MR !98
Check out this branch for the first time

Check out existing branch, if you already have it locally

About issue forks

Comments

Comment #1

1 June 2023 at 15:37

PCate created an issue. See original summary.

Comment #2

pavelculacov commented 19 June 2023 at 11:07

+ 1 Problem persist.
Not always description exists in creator_roles.
$form['creator_roles']['#description'] .= "
$description";

Comment #3

sahil.goyal commented 21 June 2023 at 10:57

Status:

Active

» Needs review

Status	File	Size
new	SS-Not-reproducable.png	254.2 KB

Hi @Pcate, I have been looked to the issue, as followed the mentioned steps to reproduce the issue, but when navigating to the newly created group type, not any error message get displayed. Could you please more information about the issue, Attaching screenshot shown no error message getting displayed.

Comment #4

gwvoigt

London, ON 🇨🇦

commented 24 July 2023 at 15:05

Status	File	Size
new	group-form-error-3364226-0.patch	893 bytes

I'm having the same issues on 3.1.0, this patch should check for the array key that is throwing the error before accessing it.

Comment #5

dbielke1986 commented 24 July 2023 at 19:28

We have the same on our page, so we need to wait for the fix and stay with 1.5.
But I will try the patch, @gwvoigt.

Comment #6

gwvoigt

London, ON 🇨🇦

commented 24 July 2023 at 20:11

The patch should work with 2.1.0 as well.

Comment #7

pcate commented 24 July 2023 at 20:54

Status:

Needs review

» Reviewed & tested by the community

I can confirm the patch applies to Group 2.1 and resolves the error message.

Comment #8

vincent.hoehn

German

Dresden, Germany

commented 25 July 2023 at 20:09

We can confirm that the patch works with 2.1. Thanks!

Comment #9

chop commented 2 August 2023 at 06:22

Queued tests of patch from #4 with Group v2.1.x

Comment #10

chop commented 2 August 2023 at 06:35

+++ b/src/Entity/Form/GroupTypeForm.php
@@ -238,7 +238,11 @@ class GroupTypeForm extends BundleEntityFormBase {
+        if (array_key_exists('creator_roles', $form)) {
+          if (array_key_exists('#description', $form['creator_roles'])) {

This might be expressed more simply using

if (isset($form['creator_roles']['#description'])) {

Comment #11

chop commented 2 August 2023 at 06:36

Version:

2.1.0

» 2.1.x-dev

Comment #12

gwvoigt

London, ON 🇨🇦

commented 2 August 2023 at 15:03

Status	File	Size
new	group-form-error-3364226-12.patch	807 bytes

Thanks chOP, I'm adding anew patch with your suggestion

Comment #13

4 August 2023 at 19:52

bbombachini opened merge request !98

Comment #14

gorkagr commented 29 November 2023 at 09:49

Hi!

Thanks for the patch. I can confirm it works as well on the 3.2.0 version too.
Best,

Comment #15

19 December 2023 at 12:40

kristiaanvandeneynde made their first commit to this issue’s fork.

Comment #16

kristiaanvandeneynde

Dutch

Antwerp, Belgium

commented 19 December 2023 at 12:42

Status:

Reviewed & tested by the community

» Needs review

Patch workflow is no longer supported as the project has moved to GitLab. Also, the fix suggested here would not work as, if you look about 10 lines higher, it was clearly intended as an extension of the render array element defined above. I've gone ahead and updated the MR to 2.3.x so we can get pipelines to run. Will then commit to 2.2.x/2.3.x/3.2.x/3.3.x once people confirm it's working.

Comment #17

gorkagr commented 19 December 2023 at 13:46

Hi @kristiaanvandeneynde

New patch works fine at least in 3.2.2 :)
thnks

Comment #18

20 December 2023 at 15:04

kristiaanvandeneynde committed 7ef36239 on 2.3.x authored by bbombachini

Issue #3364226 by gwvoigt, kristiaanvandeneynde, chOP: Form error when...

Comment #19

20 December 2023 at 15:05

kristiaanvandeneynde credited bbombachini.

Comment #20

kristiaanvandeneynde

Dutch

Antwerp, Belgium

commented 20 December 2023 at 15:05

Status:

Needs review

» Fixed

Will backport to x.2.x

Comment #21

kristiaanvandeneynde

Dutch

Antwerp, Belgium

commented 20 December 2023 at 15:07

Comment #22

20 December 2023 at 15:09

kristiaanvandeneynde committed 8e2d3ee9 on 3.3.x

Issue #3364226 by gwvoigt, kristiaanvandeneynde, chOP: Form error when...

Comment #23

20 December 2023 at 15:09

kristiaanvandeneynde committed 1d12bada on 2.2.x

Issue #3364226 by gwvoigt, kristiaanvandeneynde, chOP: Form error when...

Comment #24

20 December 2023 at 15:10

kristiaanvandeneynde committed 4034166f on 3.2.x

Issue #3364226 by gwvoigt, kristiaanvandeneynde, chOP: Form error when...

Comment #25

3 January 2024 at 15:14

Status:

Fixed

» Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

Form error when no group admin role is automatically created.

Problem/Motivation

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Issue fork group-3364226

Comments

Referenced by