Problem/Motivation

I noticed that clicking "Cancel" on the disable form uses the current user to determine the redirect to the TFA overview. This seems like a mistake, unless I am missing something.

Proposed resolution

The same logic should be applied as in TfaSetupForm (using the passed user obejct instead of the current user).

CommentFileSizeAuthor
#2 disable-form-cancel-redirect-3364126-2.patch643 byteschewi3

Comments

Chewi3 created an issue. See original summary.

chewi3’s picture

chewi3 commented
StatusFileSize
new disable-form-cancel-redirect-3364126-2.patch643 bytes

I added a patch that changes the logic on the disable form cancel callback to be similar to the TfaSetupForm cancel callback logic. Please review.

chewi3’s picture

chewi3 commented
Status: Active » Needs review

  • cmlara committed e9245133 on 2.x authored by Chewi3 
    Issue #3364126 by Chewi3: Cancel on disable form for other user...

  • cmlara committed 1c6e0a17 on 8.x-1.x authored by Chewi3 
    Issue #3364126 by Chewi3: Cancel on disable form for other user...
cmlara’s picture

cmlara
he/him
commented
Status: Needs review » Fixed

This also matches the code that is in submitForm().

I'm not sure why we have the code duplication, though resolving that I will consider out of scope for this issue.

Pushed to 8.x-1.x and 2.x.

Thank you for the patch.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.