Problem/Motivation
Following up on #3304761: Group lock settings in a details element, it seems to be more convenient to put the lock settings into the layout_settings element.
Default:


After patch:


Steps to reproduce
-
Proposed resolution
Move the lock settings and default text inside the layout_settings element.
Remaining tasks
Create patch
Review patch
User interface changes
The lock settings will be in the layout_settings element and will not stick to the bottom.
API changes
-
Data model changes
-
| Comment | File | Size | Author |
|---|---|---|---|
| lb_lock_settings_inside_layout_settings.png | 52.66 KB | tim-diels | |
| lb_lock_text_inside_layout_settings.png | 61.04 KB | tim-diels | |
| lb_lock_settings_default.png | 53.63 KB | tim-diels | |
| lb_lock_text_default.png | 70.42 KB | tim-diels |
Issue fork layout_builder_lock-3363973
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
Comments
Comment #3
tim-dielsComment #4
panchukHey @tim-diels
Thanks for your contribution, I've reviewed your MR and it looks okay. But I'll need to check if the module works correctly after these changes, and it will take some time.
Comment #6
panchukMerge into the development branch.
Thanks for your contribution.
Comment #8
tim-diels@Panchuk can you please make a release for this module so there is no need for a workaround to have this fixed in a composer setup?
Comment #9
panchukHey @tim-diels, I will try to find time to create a new release this weekend.
I want to check this issue before #3314133: Allow regions to be locked
Comment #10
panchukHey @tim-diels, a new release was created.
Can you please install and check it? Let me know if anything works incorrectly.