Problem/Motivation

Following up on #3304761: Group lock settings in a details element, it seems to be more convenient to put the lock settings into the layout_settings element.

Default:

After patch:

Steps to reproduce

-

Proposed resolution

Move the lock settings and default text inside the layout_settings element.

Remaining tasks

Create patch
Review patch

User interface changes

The lock settings will be in the layout_settings element and will not stick to the bottom.

API changes

-

Data model changes

-

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

tim-diels created an issue. See original summary.

tim-diels’s picture

Status: Active » Needs review
panchuk’s picture

Assigned: Unassigned » panchuk

Hey @tim-diels

Thanks for your contribution, I've reviewed your MR and it looks okay. But I'll need to check if the module works correctly after these changes, and it will take some time.

  • Panchuk committed 4ee9af0c on 8.x-1.x authored by tim-diels
    Issue #3363973 by tim-diels, Panchuk: Move lock settings into...
panchuk’s picture

Assigned: panchuk » Unassigned
Status: Needs review » Fixed

Merge into the development branch.
Thanks for your contribution.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

tim-diels’s picture

@Panchuk can you please make a release for this module so there is no need for a workaround to have this fixed in a composer setup?

panchuk’s picture

Hey @tim-diels, I will try to find time to create a new release this weekend.

I want to check this issue before #3314133: Allow regions to be locked

panchuk’s picture

Hey @tim-diels, a new release was created.

Can you please install and check it? Let me know if anything works incorrectly.