Problem/Motivation

Using php 8.2 I am getting deprecated functions notices.

Deprecated function: Creation of dynamic property Drupal\entitygroupfield\Plugin\Field\FieldWidget\EntityGroupFieldAutocompleteWidget::$fieldParents is deprecated in Drupal\Component\Serialization\PhpSerialize::decode() (line 21 of core/lib/Drupal/Component/Serialization/PhpSerialize.php). 
Deprecated function: Creation of dynamic property Drupal\entitygroupfield\Plugin\Field\FieldWidget\EntityGroupFieldAutocompleteWidget::$realItemCount is deprecated in Drupal\Component\Serialization\PhpSerialize::decode() (line 21 of core/lib/Drupal/Component/Serialization/PhpSerialize.php). 
Deprecated function: Creation of dynamic property Drupal\entitygroupfield\Plugin\Field\FieldWidget\EntityGroupFieldAutocompleteWidget::$fieldWrapperId is deprecated in Drupal\Component\Serialization\PhpSerialize::decode() (line 21 of core/lib/Drupal/Component/Serialization/PhpSerialize.php). 
Deprecated function: Creation of dynamic property Drupal\entitygroupfield\Plugin\Field\FieldWidget\EntityGroupFieldAutocompleteWidget::$fieldIdPrefix is deprecated in Drupal\entitygroupfield\Plugin\Field\FieldWidget\EntityGroupFieldWidgetBase->formMultipleElements() (line 593 of modules/contrib/entitygroupfield/src/Plugin/Field/FieldWidget/EntityGroupFieldWidgetBase.php).
CommentFileSizeAuthor
#6 3363829-5_6.interdiff.txt765 bytesdww
#6 3363829-6.patch956 bytesdww
#5 3363829-5-8.2-deprecateds.patch976 bytesaleix

Issue fork entitygroupfield-3363829

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

aleix created an issue. See original summary.

aleix’s picture

aleix
Primary language Catalan
Location Terrassa
commented
Issue summary: View changes

aleix opened merge request !9

aleix’s picture

aleix
Primary language Catalan
Location Terrassa
commented

This will make things easier on D10

aleix’s picture

aleix
Primary language Catalan
Location Terrassa
commented
Status: Active » Needs review
StatusFileSize
new 3363829-5-8.2-deprecateds.patch976 bytes

Adding the patch for composer purposes

dww’s picture

dww
we/he/they
commented
StatusFileSize
new 3363829-6.patch956 bytes
new 3363829-5_6.interdiff.txt765 bytes

Cool, thanks for opening this and for supplying the patch!

The patch is no longer applying to the module (neither 2.0.x nor 1.0.x branches). #5 also introduces some whitespace bugs. Here's a new patch. Let's see what the bot has to say now. 😅

  • dww committed fc7c30b9 on 2.0.x authored by aleix 
    Task #3363829: PHP 8.2: Creation of dynamic property is deprecated...

  • dww committed 57a1fd42 on 1.0.x authored by aleix 
    Task #3363829: PHP 8.2: Creation of dynamic property is deprecated...
dww’s picture

dww
we/he/they
commented
Title: PHP 8.2 deprecated functions » PHP 8.2: Creation of dynamic property is deprecated
Version: 1.0.x-dev » 2.0.x-dev
Status: Needs review » Fixed

Hrm, well, PHP 8.2 support doesn't seem to be very far along upstream in Group module, either. 😅

But I see no reason not to commit this. Pushed to 2.0.x, cherry-picked to 1.0.x and pushed.

Thanks again,
-Derek

dww closed merge request !9

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.