Problem/Motivation

Because of the way Drupal imports config, when importing the generated config from installing on a separate module the following default config key/value is added:

  _core:
    default_config_hash: <random-string>

This creates several php warnings as the expected array keys and object properties do not exist.

Steps to reproduce

  • Enable view_custom_table module
  • Create required view custom tables config via UI
  • Export generated config
  • Add exported config to a separate module's config/install directory
  • Delete config from site
  • Enable separate module (via UI or Drush)

The following php warnings will appear:

 [warning] Undefined array key "column_relations" view_custom_table.module:69
 [warning] Undefined array key "table_database" view_custom_table.module:75
 [warning] Attempt to read property "Field" on bool view_custom_table.module:79
 [warning] Attempt to read property "Type" on bool view_custom_table.module:82
 [warning] Attempt to read property "Type" on bool view_custom_table.module:87
 [warning] Attempt to read property "Field" on bool view_custom_table.module:94
 [warning] Undefined array key "table_database" view_custom_table.module:101
 [warning] Attempt to read property "Field" on bool view_custom_table.module:79
 [warning] Attempt to read property "Type" on bool view_custom_table.module:82
 [warning] Attempt to read property "Type" on bool view_custom_table.module:87
 [warning] Attempt to read property "Field" on bool view_custom_table.module:94
 [warning] Attempt to read property "Field" on bool view_custom_table.module:171
 [warning] Attempt to read property "Field" on bool view_custom_table.module:79
 [warning] Attempt to read property "Type" on bool view_custom_table.module:82
 [warning] Attempt to read property "Type" on bool view_custom_table.module:87
 [warning] Attempt to read property "Field" on bool view_custom_table.module:94
 [warning] Attempt to read property "Field" on bool view_custom_table.module:171

Proposed resolution

Hook view_custom_table_views_data() should check for the existence of array keys and object properties.

CommentFileSizeAuthor
#13 view_custom_table-3363668-13.patch14.44 KBjoseph.olstad
#4 view_custom_table-undefined_array_key_column_relations-3363668-03.patch13.9 KBsimon peacock
#2 view_custom_table-undefined_array_key_column_relations-3363668-02.patch14.21 KBsimon peacock

Issue fork view_custom_table-3363668

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

Simon Peacock created an issue. See original summary.

simon peacock’s picture

simon peacock commented
StatusFileSize
new view_custom_table-undefined_array_key_column_relations-3363668-02.patch14.21 KB
simon peacock’s picture

simon peacock commented
Version: 2.0.4 » 2.0.x-dev
simon peacock’s picture

simon peacock commented
StatusFileSize
new view_custom_table-undefined_array_key_column_relations-3363668-03.patch13.9 KB

Rollback for 2.0.4

simon peacock’s picture

simon peacock commented
Status: Active » Needs review
dmezquia’s picture

dmezquia
Primary language Spanish
Location Spain
commented

I am also getting similar warnings in the .module.

tashaharrison80 made their first commit to this issue’s fork.

tashaharrison80 opened merge request !23

joseph.olstad’s picture

joseph.olstad
Primary language French
commented
Status: Needs review » Needs work

Merge conflicts with MR 21

joseph.olstad’s picture

joseph.olstad
Primary language French
commented

To fix the conflict from 2.0.5, revert this first, then apply patch #4 , however if you want to have a patch that applies to the HEAD of 2.0.x then refer to patch #13 as there's another additional conflict in 2.0.x dev that is resolve with patch #13.

generate new patch from this.

Revert this change first.

diff --git a/view_custom_table.module b/view_custom_table.module
index 376e913..f8ce504 100644
--- a/view_custom_table.module
+++ b/view_custom_table.module
@@ -83,6 +83,10 @@ function view_custom_table_views_data() {
           $column_type_values = explode('(', $column->Type);
           $column_type = $column_type_values[0];
         }
+        else if (strpos($column->Type, ' unsigned')) {
+          $column_type_values = explode(' unsigned', $column->Type);
+          $column_type = $column_type_values[0];
+        }
         else {
           $column_type = $column->Type;
         }
joseph.olstad’s picture

joseph.olstad
Primary language French
commented

#3296864: Unsigned int-type columns are not added in hook_views_data()

joseph.olstad’s picture

joseph.olstad
Primary language French
commented
Related issues: +#3296864: Unsigned int-type columns are not added in hook_views_data()
joseph.olstad’s picture

joseph.olstad
Primary language French
commented
StatusFileSize
new view_custom_table-3363668-13.patch14.44 KB

Re-rolled by refactoring conflicts in a friendly manner.

joseph.olstad’s picture

joseph.olstad
Primary language French
commented
Status: Needs work » Needs review
joseph.olstad’s picture

joseph.olstad
Primary language French
commented
Parent issue: » #3418388: Composed primary key use wrong base_field for relationship

Status: Needs review » Needs work

The last submitted patch, 13: view_custom_table-3363668-13.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

joseph.olstad’s picture

joseph.olstad
Primary language French
commented
Status: Needs work » Fixed

Tagging this change as 2.0.6-beta1

I'll revert this if there's any regressions.

joseph.olstad’s picture

joseph.olstad
Primary language French
commented

https://www.drupal.org/project/view_custom_table/releases/2.0.6-beta1

joseph.olstad closed merge request !23

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.