Problem/Motivation

❯ phpcs --standard="Drupal,DrupalPractice" --extensions=php,module,inc,install,test,profile,theme,info,txt,md,yml,css,js .

FILE: /Users/specbee/Sites/Projects/bookable_calendar/css/bookable-calendar.css
-------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-------------------------------------------------------------------------------
 36 | ERROR | Style definitions must end with a semicolon
-------------------------------------------------------------------------------


FILE: /Users/specbee/Sites/Projects/bookable_calendar/config/optional/eca.model.process_gnq52ey.yml
---------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
---------------------------------------------------------------------------------------------------------
 14 | WARNING | Possible use of short open tags detected; found: <?xml version="1.0" encoding="UTF-8"?>
    |         |
---------------------------------------------------------------------------------------------------------


FILE: /Users/specbee/Sites/Projects/bookable_calendar/js/admin-checkin.js
-------------------------------------------------------------------------------------------
FOUND 35 ERRORS AFFECTING 4 LINES
-------------------------------------------------------------------------------------------
  8 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "NULL" but found "null"
 12 | ERROR | [x] Expected 1 space before "/"; 0 found
 12 | ERROR | [x] Expected 1 space after "/"; 0 found
 12 | ERROR | [x] Expected 1 space before "-"; 0 found
 12 | ERROR | [x] Expected 1 space after "-"; 0 found
 12 | ERROR | [x] Expected 1 space before "/"; 0 found
 12 | ERROR | [x] Expected 1 space after "/"; 0 found
 12 | ERROR | [x] Expected 1 space before "/"; 0 found
 12 | ERROR | [x] Expected 1 space after "/"; 0 found
 12 | ERROR | [x] Expected 1 space before "/"; 0 found
 12 | ERROR | [x] Expected 1 space after "/"; 0 found
 12 | ERROR | [x] Expected 1 space before "-"; 0 found
 12 | ERROR | [x] Expected 1 space after "-"; 0 found
 14 | ERROR | [x] Expected 1 space before "/"; 0 found
 14 | ERROR | [x] Expected 1 space after "/"; 0 found
 14 | ERROR | [x] Expected 1 space before "-"; 0 found
 14 | ERROR | [x] Expected 1 space after "-"; 0 found
 14 | ERROR | [x] Expected 1 space before "/"; 0 found
 14 | ERROR | [x] Expected 1 space after "/"; 0 found
 14 | ERROR | [x] Expected 1 space before "/"; 0 found
 14 | ERROR | [x] Expected 1 space after "/"; 0 found
 14 | ERROR | [x] Expected 1 space before "/"; 0 found
 14 | ERROR | [x] Expected 1 space after "/"; 0 found
 14 | ERROR | [x] Expected 1 space before "-"; 0 found
 14 | ERROR | [x] Expected 1 space after "-"; 0 found
 35 | ERROR | [x] Expected 1 space before "/"; 0 found
 35 | ERROR | [x] Expected 1 space after "/"; 0 found
 35 | ERROR | [x] Expected 1 space before "-"; 0 found
 35 | ERROR | [x] Expected 1 space after "-"; 0 found
 35 | ERROR | [x] Expected 1 space before "/"; 0 found
 35 | ERROR | [x] Expected 1 space after "/"; 0 found
 35 | ERROR | [x] Expected 1 space before "/"; 0 found
 35 | ERROR | [x] Expected 1 space after "/"; 0 found
 35 | ERROR | [x] Expected 1 space before "/"; 0 found
 35 | ERROR | [x] Expected 1 space after "/"; 0 found
-------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 35 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-------------------------------------------------------------------------------------------


FILE: /Users/specbee/Sites/Projects/bookable_calendar/bookable_calendar.install
----------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AND 1 WARNING AFFECTING 2 LINES
----------------------------------------------------------------------------------------------------------------------------------------
 287 | WARNING | Line exceeds 80 characters; contains 93 characters
 293 | ERROR   | The array declaration extends to column 82 (the limit is 80). The array content should be split up over multiple lines
----------------------------------------------------------------------------------------------------------------------------------------


FILE: /Users/specbee/Sites/Projects/bookable_calendar/bookable_calendar.module
-------------------------------------------------------------------------------------------------------------------------------
FOUND 18 ERRORS AND 2 WARNINGS AFFECTING 17 LINES
-------------------------------------------------------------------------------------------------------------------------------
  13 | WARNING | [x] Unused use statement
  17 | ERROR   | [x] There must be one blank line after the last USE statement; 2 found;
  23 | ERROR   | [x] Expected 1 blank line before function; 2 found
 311 | WARNING | [ ] Only string literals should be passed to t() where possible
 447 | ERROR   | [x] Case breaking statements must be followed by a single blank line
 494 | ERROR   | [x] Inline comments must start with a capital letter
 494 | ERROR   | [x] Inline comments must end in full-stops, exclamation marks, question marks, colons, or closing parentheses
 495 | ERROR   | [x] Equals sign not aligned with surrounding assignments; expected 1 space but found 2 spaces
 508 | ERROR   | [x] Inline comments must end in full-stops, exclamation marks, question marks, colons, or closing parentheses
 515 | ERROR   | [x] Equals sign not aligned with surrounding assignments; expected 1 space but found 2 spaces
 517 | ERROR   | [x] Inline comments must start with a capital letter
 517 | ERROR   | [x] Inline comments must end in full-stops, exclamation marks, question marks, colons, or closing parentheses
 530 | ERROR   | [x] Expected 1 blank line after function; 2 found
 555 | ERROR   | [x] Data types in @var tags need to be fully namespaced
 615 | ERROR   | [x] Data types in @var tags need to be fully namespaced
 631 | ERROR   | [x] Data types in @var tags need to be fully namespaced
 680 | ERROR   | [x] Inline comments must start with a capital letter
 680 | ERROR   | [x] Inline comments must end in full-stops, exclamation marks, question marks, colons, or closing parentheses
 693 | ERROR   | [x] Expected 1 space after FOREACH keyword; 0 found
 694 | ERROR   | [x] Inline comments must start with a capital letter
-------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 19 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-------------------------------------------------------------------------------------------------------------------------------


FILE: /Users/specbee/Sites/Projects/bookable_calendar/modules/bookable_calendar_vbo_booking/bookable_calendar_vbo_booking.module
--------------------------------------------------------------------------------------------------------------------------------
FOUND 3 ERRORS AFFECTING 3 LINES
--------------------------------------------------------------------------------------------------------------------------------
  1 | ERROR | [x] Missing file doc comment
 12 | ERROR | [x] Equals sign not aligned with surrounding assignments; expected 1 space but found 2 spaces
 22 | ERROR | [x] Expected 1 newline at end of file; 0 found
--------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 3 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------------------------------------------------------


FILE: /Users/specbee/Sites/Projects/bookable_calendar/modules/bookable_calendar_vbo_booking/src/Form/BookingContactMultipleManualForm.php
-----------------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 3 LINES
-----------------------------------------------------------------------------------------------------------------------------------------
 25 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
 55 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
 76 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
-----------------------------------------------------------------------------------------------------------------------------------------


FILE: /Users/specbee/Sites/Projects/bookable_calendar/modules/bookable_calendar_vbo_booking/src/Plugin/Action/BookOpeningInstance.php
-------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-------------------------------------------------------------------------------------------------------------------------------------
 172 | ERROR | [x] list(...) is forbidden, use [...] instead.
-------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-------------------------------------------------------------------------------------------------------------------------------------


FILE: /Users/specbee/Sites/Projects/bookable_calendar/modules/bookable_calendar_vbo_booking/src/Plugin/Action/RemoveBookingsOnOpening.php
-----------------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 14 WARNINGS AFFECTING 14 LINES
-----------------------------------------------------------------------------------------------------------------------------------------
  5 | WARNING | [x] Unused use statement
  6 | WARNING | [x] Unused use statement
  7 | WARNING | [x] Unused use statement
  8 | WARNING | [x] Unused use statement
 10 | WARNING | [x] Unused use statement
 11 | WARNING | [x] Unused use statement
 12 | WARNING | [x] Unused use statement
 13 | WARNING | [x] Unused use statement
 14 | WARNING | [x] Unused use statement
 15 | WARNING | [x] Unused use statement
 16 | WARNING | [x] Unused use statement
 17 | WARNING | [x] Unused use statement
 18 | WARNING | [x] Unused use statement
 20 | WARNING | [x] Unused use statement
-----------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 14 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-----------------------------------------------------------------------------------------------------------------------------------------


FILE: /Users/specbee/Sites/Projects/bookable_calendar/src/BookingContactAccessControlHandler.php
------------------------------------------------------------------------------------------------
FOUND 3 ERRORS AFFECTING 3 LINES
------------------------------------------------------------------------------------------------
  70 | ERROR | [x] Data types in @param tags need to be fully namespaced
  91 | ERROR | [x] Data types in @param tags need to be fully namespaced
 106 | ERROR | [x] Data types in @param tags need to be fully namespaced
------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 3 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------------------------


FILE: /Users/specbee/Sites/Projects/bookable_calendar/src/Form/SettingsForm.php
-------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
-------------------------------------------------------------------------------
 116 | WARNING | Possible useless method overriding detected
-------------------------------------------------------------------------------


FILE: /Users/specbee/Sites/Projects/bookable_calendar/src/Form/BookableCalendarOpeningForm.php
----------------------------------------------------------------------------------------------
FOUND 2 ERRORS AND 4 WARNINGS AFFECTING 5 LINES
----------------------------------------------------------------------------------------------
  5 | WARNING | [x] Unused use statement
 18 | ERROR   | [x] Data types in @var tags need to be fully namespaced
 51 | WARNING | [x] A comma should follow the last multiline array item. Found: )
 53 | WARNING | [x] A comma should follow the last multiline array item. Found: ]
 53 | ERROR   | [x] Closing parenthesis of array declaration must be on a new line
 54 | WARNING | [x] A comma should follow the last multiline array item. Found: ]
----------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 6 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------------------------------


FILE: /Users/specbee/Sites/Projects/bookable_calendar/src/Form/BookingContactCreateForm.php
-------------------------------------------------------------------------------------------
FOUND 1 ERROR AND 1 WARNING AFFECTING 2 LINES
-------------------------------------------------------------------------------------------
  5 | WARNING | [x] Unused use statement
 17 | ERROR   | [x] Data types in @var tags need to be fully namespaced
-------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-------------------------------------------------------------------------------------------


FILE: /Users/specbee/Sites/Projects/bookable_calendar/src/Form/BookableCalendarForm.php
---------------------------------------------------------------------------------------
FOUND 2 ERRORS AND 3 WARNINGS AFFECTING 5 LINES
---------------------------------------------------------------------------------------
  5 | WARNING | [x] Unused use statement
 18 | ERROR   | [x] Data types in @var tags need to be fully namespaced
 31 | ERROR   | [x] Missing function doc comment
 38 | WARNING | [x] A comma should follow the last multiline array item. Found: TRUE
 59 | WARNING | [x] A comma should follow the last multiline array item. Found: 10
---------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 5 MARKED SNIFF VIOLATIONS AUTOMATICALLY
---------------------------------------------------------------------------------------


FILE: /Users/specbee/Sites/Projects/bookable_calendar/src/Form/BookingContactForm.php
-------------------------------------------------------------------------------------
FOUND 1 ERROR AND 1 WARNING AFFECTING 2 LINES
-------------------------------------------------------------------------------------
  5 | WARNING | [x] Unused use statement
 18 | ERROR   | [x] Data types in @var tags need to be fully namespaced
-------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-------------------------------------------------------------------------------------


FILE: /Users/specbee/Sites/Projects/bookable_calendar/src/BookingListBuilder.php
--------------------------------------------------------------------------------
FOUND 4 ERRORS AFFECTING 4 LINES
--------------------------------------------------------------------------------
 20 | ERROR | [x] Data types in @var tags need to be fully namespaced
 27 | ERROR | [x] Data types in @param tags need to be fully namespaced
 29 | ERROR | [x] Data types in @param tags need to be fully namespaced
 31 | ERROR | [x] Data types in @param tags need to be fully namespaced
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 4 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------


FILE: /Users/specbee/Sites/Projects/bookable_calendar/src/BookableCalendarListBuilder.php
-----------------------------------------------------------------------------------------
FOUND 6 ERRORS AFFECTING 6 LINES
-----------------------------------------------------------------------------------------
 21 | ERROR | [x] Data types in @var tags need to be fully namespaced
 28 | ERROR | [x] Data types in @var tags need to be fully namespaced
 35 | ERROR | [x] Data types in @param tags need to be fully namespaced
 37 | ERROR | [x] Data types in @param tags need to be fully namespaced
 39 | ERROR | [x] Data types in @param tags need to be fully namespaced
 41 | ERROR | [x] Data types in @param tags need to be fully namespaced
-----------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 6 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-----------------------------------------------------------------------------------------


FILE: /Users/specbee/Sites/Projects/bookable_calendar/src/Renderer.php
----------------------------------------------------------------------------------------------------------------------------------------------
FOUND 10 ERRORS AND 8 WARNINGS AFFECTING 18 LINES
----------------------------------------------------------------------------------------------------------------------------------------------
  13 | ERROR   | [x] Missing class doc comment
  24 | ERROR   | [ ] Missing short description in doc comment
  29 | ERROR   | [ ] Missing short description in doc comment
  34 | ERROR   | [ ] Missing short description in doc comment
  39 | ERROR   | [ ] Missing short description in doc comment
  72 | ERROR   | [x] Missing function doc comment
  90 | WARNING | [x] A comma should follow the last multiline array item. Found: 'date__value'
 100 | ERROR   | [x] Expected 1 space after "="; 2 found
 113 | ERROR   | [x] Missing function doc comment
 135 | WARNING | [ ] t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
 144 | WARNING | [ ] t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
 151 | ERROR   | [x] Missing function doc comment
 158 | WARNING | [ ] t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
 165 | WARNING | [x] A comma should follow the last multiline array item. Found: 'button--small'
 175 | WARNING | [ ] t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
 187 | ERROR   | [x] Missing function doc comment
 193 | WARNING | [ ] t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
 194 | WARNING | [ ] t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
----------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 8 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------------------------------------------------------------------------------


FILE: /Users/specbee/Sites/Projects/bookable_calendar/src/Entity/BookableCalendarOpening.php
-------------------------------------------------------------------------------------------------------------------------------
FOUND 3 ERRORS AND 5 WARNINGS AFFECTING 7 LINES
-------------------------------------------------------------------------------------------------------------------------------
 221 | WARNING | [x] A comma should follow the last multiline array item. Found: 'YEARLY'
 222 | WARNING | [x] A comma should follow the last multiline array item. Found: ]
 223 | WARNING | [x] A comma should follow the last multiline array item. Found: ]
 224 | WARNING | [x] A comma should follow the last multiline array item. Found: ]
 267 | WARNING | [ ] Line exceeds 80 characters; contains 87 characters
 267 | ERROR   | [x] Inline comments must end in full-stops, exclamation marks, question marks, colons, or closing parentheses
 311 | ERROR   | [x] Expected 1 blank line after function; 0 found
 312 | ERROR   | [x] The closing brace for the class must have an empty line before it
-------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 7 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-------------------------------------------------------------------------------------------------------------------------------


FILE: /Users/specbee/Sites/Projects/bookable_calendar/src/Entity/BookableCalendarOpeningInstance.php
----------------------------------------------------------------------------------------------------
FOUND 15 ERRORS AND 6 WARNINGS AFFECTING 18 LINES
----------------------------------------------------------------------------------------------------
  12 | WARNING | [x] Unused use statement
 134 | WARNING | [x] A comma should follow the last multiline array item. Found: 'time_only'
 166 | ERROR   | [x] Functions must not contain multiple empty lines in a row; found 2 empty lines
 190 | WARNING | [ ] Possible useless method overriding detected
 195 | WARNING | [ ] Line exceeds 80 characters; contains 85 characters
 195 | ERROR   | [x] Doc comment short description must end with a full stop
 208 | ERROR   | [x] Line indented incorrectly; expected 8 spaces, found 6
 208 | ERROR   | [x] Object operator not indented correctly; expected 8 spaces but found 6
 209 | ERROR   | [x] Line indented incorrectly; expected 8 spaces, found 6
 210 | ERROR   | [x] Line indented incorrectly; expected 8 spaces, found 6
 211 | ERROR   | [x] Line indented incorrectly; expected 8 spaces, found 6
 216 | WARNING | [x] A comma should follow the last multiline array item. Found: 'date_rrule_index'
 218 | ERROR   | [x] Line indented incorrectly; expected 8 spaces, found 6
 233 | ERROR   | [x] TRUE, FALSE and NULL must be uppercase; expected "NULL" but found "null"
 234 | ERROR   | [x] TRUE, FALSE and NULL must be uppercase; expected "NULL" but found "null"
 235 | WARNING | [x] A comma should follow the last multiline array item. Found: null
 235 | ERROR   | [x] TRUE, FALSE and NULL must be uppercase; expected "NULL" but found "null"
 265 | ERROR   | [ ] Description for the @return value is missing
 279 | ERROR   | [ ] Description for the @return value is missing
 397 | ERROR   | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but found "false"
 451 | ERROR   | [x] Doc comment short description must end with a full stop
----------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 17 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------------------------------------


FILE: /Users/specbee/Sites/Projects/bookable_calendar/src/Entity/BookableCalendar.php
----------------------------------------------------------------------------------------------
FOUND 7 ERRORS AFFECTING 6 LINES
----------------------------------------------------------------------------------------------
 379 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 6
 380 | ERROR | [x] Object operator not indented correctly; expected 8 spaces but found 6
 444 | ERROR | [x] Expected "bool" but found "boolean" for function return type
 444 | ERROR | [ ] Description for the @return value is missing
 448 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "TRUE" but found "true"
 453 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "TRUE" but found "true"
 455 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but found "false"
----------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 6 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------------------------------


FILE: /Users/specbee/Sites/Projects/bookable_calendar/src/Entity/BookingContact.php
----------------------------------------------------------------------------------------------------------------------------------------------
FOUND 2 ERRORS AND 2 WARNINGS AFFECTING 3 LINES
----------------------------------------------------------------------------------------------------------------------------------------------
 287 | WARNING | [ ] t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
 287 | WARNING | [ ] Only string literals should be passed to t() where possible
 411 | ERROR   | [x] Expected 1 blank line after function; 2 found
 414 | ERROR   | [x] The closing brace for the class must have an empty line before it
----------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------------------------------------------------------------------------------


FILE: /Users/specbee/Sites/Projects/bookable_calendar/src/BookableCalendarViewBuilder.php
-----------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-----------------------------------------------------------------------------------------
 14 | ERROR | Missing short description in doc comment
-----------------------------------------------------------------------------------------


FILE: /Users/specbee/Sites/Projects/bookable_calendar/src/Plugin/views/field/BookLink.php
-----------------------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
-----------------------------------------------------------------------------------------
 17 | ERROR | [x] Missing function doc comment
 23 | ERROR | [x] Missing function doc comment
-----------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-----------------------------------------------------------------------------------------


FILE: /Users/specbee/Sites/Projects/bookable_calendar/src/Plugin/Validation/Constraint/CalendarOpeningIsActiveValidator.php
---------------------------------------------------------------------------------------------------------------------------
FOUND 2 ERRORS AND 1 WARNING AFFECTING 3 LINES
---------------------------------------------------------------------------------------------------------------------------
  5 | WARNING | [x] Unused use statement
 20 | ERROR   | [x] TRUE, FALSE and NULL must be uppercase; expected "TRUE" but found "true"
 23 | ERROR   | [x] Data types in @var tags need to be fully namespaced
---------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 3 MARKED SNIFF VIOLATIONS AUTOMATICALLY
---------------------------------------------------------------------------------------------------------------------------


FILE: /Users/specbee/Sites/Projects/bookable_calendar/src/Plugin/Validation/Constraint/CalendarOpeningVacancy.php
-----------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-----------------------------------------------------------------------------------------------------------------
 18 | ERROR | Missing member variable doc comment
-----------------------------------------------------------------------------------------------------------------


FILE: /Users/specbee/Sites/Projects/bookable_calendar/src/Plugin/Validation/Constraint/CalendarOpeningMaxPartySize.php
----------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------------------------------------------------------
 18 | ERROR | Missing member variable doc comment
----------------------------------------------------------------------------------------------------------------------


FILE: /Users/specbee/Sites/Projects/bookable_calendar/src/Plugin/Validation/Constraint/CalendarOpeningTooSoonValidator.php
--------------------------------------------------------------------------------------------------------------------------
FOUND 2 ERRORS AND 1 WARNING AFFECTING 3 LINES
--------------------------------------------------------------------------------------------------------------------------
  5 | WARNING | [x] Unused use statement
 20 | ERROR   | [x] TRUE, FALSE and NULL must be uppercase; expected "TRUE" but found "true"
 23 | ERROR   | [x] Data types in @var tags need to be fully namespaced
--------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 3 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------------------------------------------------


FILE: /Users/specbee/Sites/Projects/bookable_calendar/src/Plugin/Validation/Constraint/CalendarOpeningMaxPartySizeValidator.php
-------------------------------------------------------------------------------------------------------------------------------
FOUND 2 ERRORS AND 1 WARNING AFFECTING 3 LINES
-------------------------------------------------------------------------------------------------------------------------------
  5 | WARNING | [x] Unused use statement
 20 | ERROR   | [x] TRUE, FALSE and NULL must be uppercase; expected "TRUE" but found "true"
 23 | ERROR   | [x] Data types in @var tags need to be fully namespaced
-------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 3 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-------------------------------------------------------------------------------------------------------------------------------


FILE: /Users/specbee/Sites/Projects/bookable_calendar/src/Plugin/Validation/Constraint/CalendarOpeningIsActive.php
------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
------------------------------------------------------------------------------------------------------------------
 18 | ERROR | Missing member variable doc comment
------------------------------------------------------------------------------------------------------------------


FILE: /Users/specbee/Sites/Projects/bookable_calendar/src/Plugin/Validation/Constraint/CalendarOpeningMaxBookingsClaimedSitewideByUser.php
------------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
------------------------------------------------------------------------------------------------------------------------------------------
 18 | ERROR | Missing member variable doc comment
------------------------------------------------------------------------------------------------------------------------------------------


FILE: /Users/specbee/Sites/Projects/bookable_calendar/src/Plugin/Validation/Constraint/CalendarOpeningTooFarAway.php
--------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------------------------------------------
 18 | ERROR | Missing member variable doc comment
--------------------------------------------------------------------------------------------------------------------


FILE: /Users/specbee/Sites/Projects/bookable_calendar/src/Plugin/Validation/Constraint/CalendarOpeningNotInPast.php
-------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-------------------------------------------------------------------------------------------------------------------
 18 | ERROR | Missing member variable doc comment
-------------------------------------------------------------------------------------------------------------------


FILE: /Users/specbee/Sites/Projects/bookable_calendar/src/Plugin/Validation/Constraint/CalendarOpeningVacancyValidator.php
--------------------------------------------------------------------------------------------------------------------------
FOUND 2 ERRORS AND 1 WARNING AFFECTING 3 LINES
--------------------------------------------------------------------------------------------------------------------------
  5 | WARNING | [x] Unused use statement
 20 | ERROR   | [x] TRUE, FALSE and NULL must be uppercase; expected "TRUE" but found "true"
 23 | ERROR   | [x] Data types in @var tags need to be fully namespaced
--------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 3 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------------------------------------------------


FILE: /Users/specbee/Sites/Projects/bookable_calendar/src/Plugin/Validation/Constraint/CalendarOpeningMaxBookingsClaimedSitewideByUserValidator.php
---------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 4 ERRORS AND 3 WARNINGS AFFECTING 7 LINES
---------------------------------------------------------------------------------------------------------------------------------------------------
  5 | WARNING | [x] Unused use statement
 20 | ERROR   | [x] TRUE, FALSE and NULL must be uppercase; expected "TRUE" but found "true"
 23 | ERROR   | [x] Data types in @var tags need to be fully namespaced
 25 | WARNING | [ ] Unused variable $parent_calendar.
 35 | WARNING | [x] A comma should follow the last multiline array item. Found: 'booking_instance'
 51 | ERROR   | [x] Expected 1 blank line after function; 0 found
 52 | ERROR   | [x] The closing brace for the class must have an empty line before it
---------------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 6 MARKED SNIFF VIOLATIONS AUTOMATICALLY
---------------------------------------------------------------------------------------------------------------------------------------------------


FILE: /Users/specbee/Sites/Projects/bookable_calendar/src/Plugin/Validation/Constraint/CalendarOpeningTooFarAwayValidator.php
-----------------------------------------------------------------------------------------------------------------------------
FOUND 2 ERRORS AND 1 WARNING AFFECTING 3 LINES
-----------------------------------------------------------------------------------------------------------------------------
  5 | WARNING | [x] Unused use statement
 20 | ERROR   | [x] TRUE, FALSE and NULL must be uppercase; expected "TRUE" but found "true"
 23 | ERROR   | [x] Data types in @var tags need to be fully namespaced
-----------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 3 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-----------------------------------------------------------------------------------------------------------------------------


FILE: /Users/specbee/Sites/Projects/bookable_calendar/src/Plugin/Validation/Constraint/CalendarOpeningTooSoon.php
-----------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-----------------------------------------------------------------------------------------------------------------
 18 | ERROR | Missing member variable doc comment
-----------------------------------------------------------------------------------------------------------------


FILE: /Users/specbee/Sites/Projects/bookable_calendar/src/Plugin/Validation/Constraint/CalendarOpeningMaxBookingsClaimedByUser.php
----------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------------------------------------------------------------------
 18 | ERROR | Missing member variable doc comment
----------------------------------------------------------------------------------------------------------------------------------


FILE: /Users/specbee/Sites/Projects/bookable_calendar/src/Plugin/Validation/Constraint/CalendarOpeningMaxBookingsClaimedByUserValidator.php
-------------------------------------------------------------------------------------------------------------------------------------------
FOUND 4 ERRORS AND 4 WARNINGS AFFECTING 8 LINES
-------------------------------------------------------------------------------------------------------------------------------------------
  5 | WARNING | [x] Unused use statement
 20 | ERROR   | [x] TRUE, FALSE and NULL must be uppercase; expected "TRUE" but found "true"
 23 | ERROR   | [x] Data types in @var tags need to be fully namespaced
 33 | WARNING | [x] A comma should follow the last multiline array item. Found: 'booking_instance'
 40 | WARNING | [x] A comma should follow the last multiline array item. Found: 'booking_opening'
 44 | WARNING | [x] A comma should follow the last multiline array item. Found: 'bookable_calendar'
 54 | ERROR   | [x] Expected 1 blank line after function; 0 found
 55 | ERROR   | [x] The closing brace for the class must have an empty line before it
-------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 8 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-------------------------------------------------------------------------------------------------------------------------------------------


FILE: /Users/specbee/Sites/Projects/bookable_calendar/src/Plugin/Validation/Constraint/CalendarOpeningNotInPastValidator.php
----------------------------------------------------------------------------------------------------------------------------
FOUND 2 ERRORS AND 1 WARNING AFFECTING 3 LINES
----------------------------------------------------------------------------------------------------------------------------
  5 | WARNING | [x] Unused use statement
 20 | ERROR   | [x] TRUE, FALSE and NULL must be uppercase; expected "TRUE" but found "true"
 23 | ERROR   | [x] Data types in @var tags need to be fully namespaced
----------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 3 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------------------------------------------------------------


FILE: /Users/specbee/Sites/Projects/bookable_calendar/src/Controller/BookableCalendarController.php
---------------------------------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
---------------------------------------------------------------------------------------------------
 16 | ERROR | [x] Data types in @var tags need to be fully namespaced
 37 | ERROR | [x] Data types in @param tags need to be fully namespaced
---------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
---------------------------------------------------------------------------------------------------


FILE: /Users/specbee/Sites/Projects/bookable_calendar/src/Controller/BookableCalendarApiController.php
------------------------------------------------------------------------------------------------------
FOUND 20 ERRORS AND 3 WARNINGS AFFECTING 20 LINES
------------------------------------------------------------------------------------------------------
  26 | ERROR   | [x] Data types in @var tags need to be fully namespaced
  47 | ERROR   | [x] Data types in @var tags need to be fully namespaced
  54 | ERROR   | [x] Data types in @param tags need to be fully namespaced
  56 | ERROR   | [x] Data types in @param tags need to be fully namespaced
  94 | ERROR   | [x] Missing function doc comment
 125 | ERROR   | [ ] Description for the @return value is missing
 183 | WARNING | [ ] Line exceeds 80 characters; contains 82 characters
 185 | ERROR   | [ ] Missing parameter comment
 185 | ERROR   | [x] Data types in @param tags need to be fully namespaced
 186 | ERROR   | [x] Separate the @param and @return sections by a blank line.
 186 | ERROR   | [ ] If there is no return value for a function, there must not be a @return tag.
 186 | ERROR   | [ ] Description for the @return value is missing
 203 | WARNING | [x] A comma should follow the last multiline array item. Found: ]
 223 | WARNING | [x] A comma should follow the last multiline array item. Found: $validation_errors
 253 | ERROR   | [x] Data types in @param tags need to be fully namespaced
 255 | ERROR   | [x] Data types in @param tags need to be fully namespaced
 258 | ERROR   | [x] Data types in @return tags need to be fully namespaced
 333 | ERROR   | [x] Data types in @param tags need to be fully namespaced
 336 | ERROR   | [x] Data types in @return tags need to be fully namespaced
 351 | ERROR   | [x] Data types in @param tags need to be fully namespaced
 354 | ERROR   | [x] Data types in @return tags need to be fully namespaced
 371 | ERROR   | [x] Data types in @param tags need to be fully namespaced
 374 | ERROR   | [x] Data types in @return tags need to be fully namespaced
------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 18 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------------------------------


FILE: /Users/specbee/Sites/Projects/bookable_calendar/src/BookingContactListBuilder.php
---------------------------------------------------------------------------------------
FOUND 6 ERRORS AFFECTING 6 LINES
---------------------------------------------------------------------------------------
 21 | ERROR | [x] Data types in @var tags need to be fully namespaced
 28 | ERROR | [x] Data types in @var tags need to be fully namespaced
 35 | ERROR | [x] Data types in @param tags need to be fully namespaced
 37 | ERROR | [x] Data types in @param tags need to be fully namespaced
 39 | ERROR | [x] Data types in @param tags need to be fully namespaced
 41 | ERROR | [x] Data types in @param tags need to be fully namespaced
---------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 6 MARKED SNIFF VIOLATIONS AUTOMATICALLY
---------------------------------------------------------------------------------------


FILE: /Users/specbee/Sites/Projects/bookable_calendar/src/DateFormatter.php
----------------------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 1 LINE
----------------------------------------------------------------------------------------
 58 | ERROR | [x] Line indented incorrectly; expected 8 spaces, found 6
 58 | ERROR | [x] Object operator not indented correctly; expected 8 spaces but found 6
----------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------------------------


FILE: /Users/specbee/Sites/Projects/bookable_calendar/src/Notification.php
--------------------------------------------------------------------------
FOUND 12 ERRORS AND 1 WARNING AFFECTING 13 LINES
--------------------------------------------------------------------------
  5 | WARNING | [x] Unused use statement
 23 | ERROR   | [x] Data types in @var tags need to be fully namespaced
 30 | ERROR   | [x] Data types in @var tags need to be fully namespaced
 37 | ERROR   | [x] Data types in @var tags need to be fully namespaced
 51 | ERROR   | [x] Data types in @param tags need to be fully namespaced
 53 | ERROR   | [x] Data types in @param tags need to be fully namespaced
 55 | ERROR   | [x] Data types in @param tags need to be fully namespaced
 57 | ERROR   | [x] Data types in @param tags need to be fully namespaced
 59 | ERROR   | [x] Data types in @param tags need to be fully namespaced
 61 | ERROR   | [x] Data types in @param tags need to be fully namespaced
 63 | ERROR   | [x] Data types in @param tags need to be fully namespaced
 83 | ERROR   | [ ] Parameter $cancel is not described in comment
 86 | ERROR   | [x] Data types in @param tags need to be fully namespaced
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 12 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------


FILE: /Users/specbee/Sites/Projects/bookable_calendar/src/BookableCalendarOpeningListBuilder.php
------------------------------------------------------------------------------------------------
FOUND 6 ERRORS AFFECTING 6 LINES
------------------------------------------------------------------------------------------------
 21 | ERROR | [x] Data types in @var tags need to be fully namespaced
 28 | ERROR | [x] Data types in @var tags need to be fully namespaced
 35 | ERROR | [x] Data types in @param tags need to be fully namespaced
 37 | ERROR | [x] Data types in @param tags need to be fully namespaced
 39 | ERROR | [x] Data types in @param tags need to be fully namespaced
 41 | ERROR | [x] Data types in @param tags need to be fully namespaced
------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 6 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------------------------


FILE: /Users/specbee/Sites/Projects/bookable_calendar/src/BookableCalendarOpeningInstanceViewBuilder.php
--------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------------------------------
 14 | ERROR | Missing short description in doc comment
--------------------------------------------------------------------------------------------------------

Time: 1.47 secs; Memory: 16MB

Steps to reproduce

phpcs --standard=“Drupal,DrupalPractice” --extensions=php,module,inc,install,test,profile,theme,info,txt,md,yml,css,js .

Issue fork bookable_calendar-3362843

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

sidharth_soman created an issue. See original summary.

sidharth_soman’s picture

sidharth_soman commented
Status: Active » Needs work

I am working on this.

sidharth_soman opened merge request !34

sidharth_soman’s picture

sidharth_soman commented
Assigned: sidharth_soman » Unassigned
Status: Needs work » Needs review

I've fixed a total of about 270 phpcs issues. The only ones left are those related to filling out or editing documentation comments. It would be ideal if these are resolved by the maintainers themselves.

I've issued an MR for everything else. Please review.

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Status: Needs review » Needs work
Issue tags: +Needs issue summary update

The issue summary should always describe what the issue is trying to fix and, in the case of coding standards issues, show which command and arguments have been used and which report that command shown.

josh.fabean’s picture

josh.fabean
Location Florida
commented

Thanks I'll look those over. I do personally have some confusion about what is proper for defining types in doc blocks as phpcs says give the full path but I'm pretty sure when you say --standard="Drupal" but when you say --standard="DrupalPractice" it says not to do that.

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented

API documentation and comment standards says:

Immediately after an @tag (@param, @return, @var, etc.), class and interface names must always include the fully-qualified namespace.

[For type-hinting] Always prefix types with the fully-qualified namespace for classes and interfaces (beginning with a backslash). If the class/interface is in the global namespace, prefix by a backslash.

Drupal and DrupalPractice are standards with different rules, but one does not exclude the other one. That's why they should be used together.

imustakim’s picture

imustakim commented
Issue summary: View changes
Issue tags: -Needs issue summary update

Issue summary updated.

josh.fabean’s picture

josh.fabean
Location Florida
commented

Got it, I was confused what Drupal Rector does vs phpcs. Getting this merged in.

josh.fabean’s picture

josh.fabean
Location Florida
commented
Assigned: Unassigned » josh.fabean
Status: Needs work » Fixed
josh.fabean’s picture

josh.fabean
Location Florida
commented
Status: Fixed » Closed (fixed)