Problem/Motivation

Some helpdesks do not need any user synchronization for several reasons:

  • Helpdesk and user data are in the same ecosystem
  • User data are handled otherwise
  • etc.

Proposed resolution

Add a checkbox to the general settings of the framework. To be compatible with earlier versions, the default will be with synchronization enabled.

Issue fork helpdesk_integration-3362366

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

danielspeicher created an issue. See original summary.

danielspeicher opened merge request !1

danielspeicher’s picture

danielspeicher commented
Status: Active » Needs review
jurgenhaas’s picture

jurgenhaas
he/him
Primary language German
Location Gottmadingen
commented
Status: Needs review » Needs work

Have added some remarks.

danielspeicher’s picture

danielspeicher commented
Status: Needs work » Needs review
jurgenhaas’s picture

jurgenhaas
he/him
Primary language German
Location Gottmadingen
commented
Status: Needs review » Reviewed & tested by the community

Just fixed a coding standard issue and renamed the variable from userSync to user_sync since this is the name that's been used for the config entity property according to the annotation of the entity. I then realized that the config schema needed to be updated as well.

The getter for boolean config values should do the casting for some reason. I have seen issues in the past where reading config yamls didn't do that properly sometimes and we then had an integer value instead.

Otherwise, this looks good to go.

danielspeicher’s picture

danielspeicher commented

Thx a lot.

danielspeicher’s picture

danielspeicher commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.