Problem/Motivation

Module is not compatible with D10

Steps to reproduce

* Run upgrade status report:

- Value of core_version_requirement: ^8 || ^9 is not compatible with the next major version of Drupal core. See https://drupal.org/node/3070687.

- Call to deprecated function module_load_include(). Deprecated in drupal:9.4.0 and is removed from drupal:11.0.0. Use Drupal::moduleHandler()->loadInclude($module, $type, $name = NULL). Note that including code from uninstalled extensions is no longer supported.

Proposed resolution

* updated .info.yml file and change the deprecated function with D10 compatibility.

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#9 d10-compatability-3362287-9.diff1.11 KBvakulrai

Issue fork webform_hierarchy-3362287

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

jabonillac@gmail.com created an issue. See original summary.

jabonillac@gmail.com’s picture

jabonillac@gmail.com commented
Issue summary: View changes

sakthi_dev made their first commit to this issue’s fork.

sakthi_dev opened merge request !1

sakthi_dev’s picture

sakthi_dev commented
Status: Active » Needs review

Please review.

anand.toshniwal93’s picture

anand.toshniwal93 commented
Status: Needs review » Needs work

After applying above patch am still getting an below error 

Error : Call to undefined function _template_preprocess_webform_composite() in template_preprocess_webform_hierarchy() (line 28 of /app/docroot/modules/contrib/webform_hierarchy/webform_hierarchy.module )

I was able to get this working by replacing this
\Drupal::moduleHandler()->loadInclude('inc', 'webform', 'includes/webform.theme.template');

with \Drupal::moduleHandler()->loadInclude('webform', 'inc', 'includes/webform.theme.template');

anand.toshniwal93’s picture

anand.toshniwal93 commented
Status: Needs work » Needs review

noorulshameera made their first commit to this issue’s fork.

vakulrai’s picture

vakulrai commented
StatusFileSize
new d10-compatability-3362287-9.diff1.11 KB

Attaching the patch for visibility:

Bushra Shaikh’s picture

Bushra Shaikh commented
Status: Needs review » Needs work

I applied patch #9 got below error:

error: patch failed: webform_hierarchy.info.yml:2
error: webform_hierarchy.info.yml: patch does not apply
error: patch failed: webform_hierarchy.module:24
error: webform_hierarchy.module: patch does not apply

maximpodorov’s picture

maximpodorov commented
Status: Needs work » Fixed

Committed. Thank you.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.