Problem/Motivation

9.5.x now shows a warning in the status report

Covered until 2023-Nov. / Update to a supported minor version soon to continue receiving security updates.

This is controlled by a constant in \Drupal\update\ProjectSecurityData:

const SECURITY_COVERAGE_ENDING_WARN_DATE_9_5 = '2023-05-14';

Users have reported that the warning is poorly worded. This is for two reasons:

  1. There are no more supported minor versions for Drupal 9.5; it should probably tell the user they need to update to Drupal 10.
  2. 9.4.x is still supported for another month, so the warning feels like it's a bit early.

Steps to reproduce

Install 9.5.x and update.module.

Proposed resolution

Discussed with the release managers. @catch said:

Should it say 'Update to Drupal 10 soon to continue receiving security updates' and maybe push it back until the day of 10.1.0's release?

@xjm said:

I think maybe it's a typo and it was supposed to be 2023-06-14 but not sure.

Not that changing it now will not have much impact -- at most it will help from the June bugfix release to the 10.1 release date. I guess at least removing the word "minor" would help until D9's EOL.

Remaining tasks

Remove 'minor' from the message.

User interface changes

Removed 'minor' from this message

API changes

None.

Data model changes

None.

Release notes snippet

Issue fork drupal-3361728

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

longwave created an issue. See original summary.

xjm’s picture

Issue summary: View changes

Adding missing keyword "not" from my slack tell. 😂

xjm’s picture

Title: Update warning in 9.5 is poorly worded » Make 10.x EOL warnings better than the 9.5.x one
Version: 9.5.x-dev » 11.x-dev
Status: Active » Postponed

Converting this to an issue for fixing similar messages for Drupal 10 (once we add them), and marking postponed, since it's definitely not fixable in D9 anymore.

quietone’s picture

Status: Postponed » Active
quietone’s picture

Status: Active » Postponed

Changing the status was a mistake.

quietone’s picture

Issue summary: View changes
Status: Postponed » Needs review
Parent issue: » #3449815: [meta] Requirements for tagging 11.0.0-rc1
StatusFileSize
new26.55 KB

I agree with #3 that the warning date for 9.5 is likely a typo.

The message is created in getDateEndRequirement which does not have information about the next major. That is why I implemented the suggestion to remove 'minor'. It is by the simplest action to take to improve the message.

quietone’s picture

Title: Make 10.x EOL warnings better than the 9.5.x one » Make 10.x EOL warning better than the 9.5.x one
smustgrave’s picture

Status: Needs review » Needs work

@quietone did you mean to push a change?

quietone’s picture

Status: Needs work » Needs review

Yes, I did. This time I have made an MR.

smustgrave’s picture

Status: Needs review » Reviewed & tested by the community

Cool, have done that before too.

Change seems straight forward enough

longwave’s picture

Status: Reviewed & tested by the community » Needs work

Can we also change the date format to something more human readable while we are here?

Covered until 2023-Nov.

Suggested change:

Covered until November 2023.

xjm’s picture

The existing date formats were chosen for being reasonably understandable internationally, rather than having to get the date formatter involved for a status report message.

If we want to propose changing that too, I would suggest a separate issue.

ankitv18’s picture

Status: Needs work » Reviewed & tested by the community

RTBC+1 on the basis of @xjm comment#13

  • longwave committed bd6f3290 on 10.4.x
    Issue #3361728 by quietone, longwave, xjm: Make 10.x EOL warning better...

  • longwave committed d49ffa40 on 11.x
    Issue #3361728 by quietone, longwave, xjm: Make 10.x EOL warning better...
longwave’s picture

Version: 11.x-dev » 10.4.x-dev
Status: Reviewed & tested by the community » Fixed

Committed to 11.x and 10.4.x as this is a translatable string change.

Committed and pushed d49ffa40d1 to 11.x and bd6f329075 to 10.4.x. Thanks!

  • longwave committed 772ff7d1 on 11.0.x
    Issue #3361728 by quietone, longwave, xjm: Make 10.x EOL warning better...
longwave’s picture

...and backported to 11.0.x given this is tagged under the meta for 11.0.0-beta2.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

xjm’s picture

Amending attribution.