Not listing the module's dependencies in the composer.json file results in Drupal's packagist system generating it from the info file's dependencies list, which results in Composer thinking that "drupal/webform_node" is a separate dependency. This results in some oddities, e.g. this problem adding it to a Drupal 10 site: https://github.com/mglaman/composer-drupal-lenient/issues/15
| Comment | File | Size | Author |
|---|---|---|---|
| #2 | webform_migrate-n3361646-2.patch | 333 bytes | damienmckenna |
Comments
Comment #2
damienmckennaThis adds drupal/webform as a Composer dependency.
Comment #3
solideogloria commentedLooks good to me.
Comment #4
solideogloria commentedJust wondering, shouldn't the core Migrate module also be a dependency? All throughout the module are references to it...
It's also missing from the .info.yml file.
Comment #5
damienmckennaYes, migrate should be listed as a dependency in the info.yml files, but that's a separate thing to fixing the composer.json file.
Comment #6
solideogloria commentedWell, if we're fixing composer.json now, shouldn't we add the dependency there as well?
Comment #7
damienmckennaMigrate is part of core, so adding it to composer.json is a waste of time.
Comment #8
solideogloria commentedOh, right. Never mind.
Comment #9
solideogloria commentedCreated a MR in a separate issue.
#3383227: Missing dependencies in .info.yml
Comment #11
ruslan piskarov