Not listing the module's dependencies in the composer.json file results in Drupal's packagist system generating it from the info file's dependencies list, which results in Composer thinking that "drupal/webform_node" is a separate dependency. This results in some oddities, e.g. this problem adding it to a Drupal 10 site: https://github.com/mglaman/composer-drupal-lenient/issues/15

CommentFileSizeAuthor
#2 webform_migrate-n3361646-2.patch333 bytesdamienmckenna

Comments

DamienMcKenna created an issue. See original summary.

damienmckenna’s picture

Status: Active » Needs review
StatusFileSize
new333 bytes

This adds drupal/webform as a Composer dependency.

solideogloria’s picture

Status: Needs review » Reviewed & tested by the community

Looks good to me.

solideogloria’s picture

Just wondering, shouldn't the core Migrate module also be a dependency? All throughout the module are references to it...

It's also missing from the .info.yml file.

damienmckenna’s picture

Yes, migrate should be listed as a dependency in the info.yml files, but that's a separate thing to fixing the composer.json file.

solideogloria’s picture

Well, if we're fixing composer.json now, shouldn't we add the dependency there as well?

damienmckenna’s picture

Migrate is part of core, so adding it to composer.json is a waste of time.

solideogloria’s picture

Oh, right. Never mind.

solideogloria’s picture

Created a MR in a separate issue.

#3383227: Missing dependencies in .info.yml

ruslan piskarov’s picture

Version: 8.x-1.x-dev » 2.0.x-dev
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.