The upstream dependency esolitos/pwnedpasswords depends on guzzle 6, which means this module can't be used with Drupal 10, which depends on guzzle 7.

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

nicrodgers created an issue. See original summary.

nicrodgers’s picture

Assigned: Unassigned » nicrodgers

I've created a PR for the upstream dependency here https://github.com/esolitos/pwnedpasswords/pull/2

esolitos’s picture

Status: Active » Needs work

Thank you for the feedback, much appreciated.
I reviewed the PR on esolitos/pwnedpasswords, I've added a small suggestion to maintain compatibility.

nicrodgers’s picture

Assigned: nicrodgers » Unassigned
Status: Needs work » Needs review

Thanks for the feedback, I've updated the upstream PR accordingly. And sorry - I hadn't realised you maintained the Drupal module and the upstream library! That's great, it certainly makes this much easier. So once the upstream PR is merged, we can close the d.o fork down and mark this as fixed, because nothing should be needed on the Drupal side.

esolitos’s picture

Status: Needs review » Fixed

PR accepted, merged and new a release is set up.

Thanks for the contribution!


And sorry - I hadn't realised you maintained the Drupal module and the upstream library!

No worries. :)

  • nicrodgers authored aa2ae364 on 8.x-1.x
    Issue #3359629 by nicrodgers: Drupal 10 / Guzzle 7 compatibility
    
esolitos’s picture

PS: I added a commit which simply removed the "@alpha" requirement, mostly to ensure you got credited. :)

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.