Allow to import LAST-MODIFIED as revision time stamp [#3358715]

Problem/Motivation

The latest change is usually the timestamp of the revision. When I assign LAST-MODIFIED to the latest revision timestamp I get the following Warning message:

The content Dresdner Mathematisches Seminar konnte mit den folgenden Fehlern nicht validiert werden:

revision_timestamp.0.value: Dieser Wert sollte vom korrekten primitiven Datentyp sein.

Bitte überprüfen Sie die Zuordnungen.

Steps to reproduce

Add a feed iCal type and with the association “LAST-MODIFIED” ⇒ “revision_timestamp”
Add a feed with the public iCal url from a google calendar

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Issue fork feeds_ical-3358715

Show commands

Start within a Git clone of the project using the version control instructions.

Add & fetch this issue fork’s repository

Or, if you do not have SSH keys set up on git.drupalcode.org:

Add & fetch this issue fork’s repository

3358715-last-modified-fix changes, plain diff MR !16 / changes, plain diff MR !12
Check out this branch for the first time

Check out existing branch, if you already have it locally

1 hidden branch

2.x-dev

changes, plain diff MR !15 /

changes, plain diff MR !11

Check out this branch for the first time

Check out existing branch, if you already have it locally

About issue forks

Comments

Comment #1

7 May 2023 at 17:22

keinstein created an issue. See original summary.

Comment #2

5 November 2024 at 19:17

ben.hamelin made their first commit to this issue’s fork.

Comment #3

5 November 2024 at 19:18

ben.hamelin opened merge request !11

Comment #4

5 November 2024 at 20:24

ben.hamelin closed merge request !11

Comment #5

ben.hamelin

he/him

English

Adirondack Mountains, NY

commented 6 March 2025 at 16:04

@keinstein Did some work on this today, and have a fix that provides LAST-MODIFIED as a timestamp like Drupal expects. However, it's worth noting this Feeds issue: https://www.drupal.org/project/feeds/issues/3060308

Without a presave or postsave hook the default Drupal entity update handler is going to use the current time regardless of what you have in the feed. This fix is still needed to ensure we have a properly formatted timestamp for mapping.