Problem/Motivation

With the 1.1.31 release of mglaman/phpstan-drupal, we see our "updated deps" test-runs fail on both 10.0.x and 10.1.x.

(This is not the only reason, see #3356337: Fix incorrect type hint and make daily "updated deps" QA jobs pass )

Steps to reproduce

https://www.drupal.org/node/3060/qa

Proposed resolution

- Upgrade mglaman/phpstan-drupal to 1.1.31
- Create a new baseline
- Bump version of mglaman/phpstan-drupal in composer.lock to 1.1.31 , since the newly created baseline won't pass on 1.1.31

User interface changes

API changes

Data model changes

Release notes snippet

CommentFileSizeAuthor
#3 3357114-10.0.x-3.patch5.81 KBspokje
#2 3357114-10.1.x-2.patch6.54 KBspokje

Comments

Spokje created an issue. See original summary.

spokje’s picture

spokje
Primary language Dutch
commented
StatusFileSize
new 3357114-10.1.x-2.patch6.54 KB
spokje’s picture

spokje
Primary language Dutch
commented
StatusFileSize
new 3357114-10.0.x-3.patch5.81 KB
spokje’s picture

spokje
Primary language Dutch
commented
Status: Active » Needs review
smustgrave’s picture

smustgrave commented
Status: Needs review » Needs work
Issue tags: +Needs Review Queue Initiative

Seems to have an issue for 10.1

spokje’s picture

spokje
Primary language Dutch
commented
Status: Needs work » Needs review

Seems to have an issue for 10.1

Not really

- I accidentally tested the 10.0.x patch against 10.1.x: That didn't apply (of course)
- The "updated deps" run on 10.1.x still fails (although fails less), because of:

(This is not the only reason, see #3356337: Fix incorrect type hint and make daily "updated deps" QA jobs pass

smustgrave’s picture

smustgrave commented
Status: Needs review » Reviewed & tested by the community

Ah you're right. Long week.

mondrake’s picture

mondrake
Location 🇮🇹
commented

Why is there a baseline addition? Is that related to the introduction of the TrustedCallback attribute?

spokje’s picture

spokje
Primary language Dutch
commented

Why is there a baseline addition? Is that related to the introduction of the TrustedCallback attribute?

Yep, looks like a regression.
Opened https://github.com/mglaman/phpstan-drupal/issues/543

catch’s picture

catch
he/him
Primary language English
commented

Should we wait for https://github.com/mglaman/phpstan-drupal/issues/543 or just update again when that's fixed?

spokje’s picture

spokje
Primary language Dutch
commented

I would say: Update now, there are also more accessCheck issues with the new version, but haven't got around to admin/fix those.

-2/+1 in the baseline seems like a win :)

catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Needs work

Needs a re-roll.

spokje’s picture

spokje
Primary language Dutch
commented
Status: Needs work » Reviewed & tested by the community

Unsure what needs re-rolling?

Both the 10.0.x and 10.1.x-patch still apply, back to RTBC.

  • catch committed a7078099 on 10.0.x 
    Issue #3357114 by Spokje: Update mglaman/phpstan-drupal and help make...

  • catch committed 9121ea0b on 10.1.x 
    Issue #3357114 by Spokje: Update mglaman/phpstan-drupal and help make...
catch’s picture

catch
he/him
Primary language English
commented
Version: 10.1.x-dev » 10.0.x-dev
Status: Reviewed & tested by the community » Fixed

Same confusions as #5, even though I'd already read it.

Committed/pushed the respective patches to 10.1.x and 10.0.x, thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.