Problem/Motivation

Currently we do not call any of the s3fs hooks during the bucket validation process.

This means that we are not testing that the bucket is functioning with possible hooks and if a hook modification is necessary such as in #3356190: Unable to write to a bucket that has object lock enabled bucket validation can fail.

Steps to reproduce

See #3356190: Unable to write to a bucket that has object lock enabled

Proposed resolution

Call hooks as part of bucket validation

Remaining tasks

Patch

User interface changes

None

API changes

None

Data model changes

None

Issue fork s3fs-3356781

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

cmlara created an issue. See original summary.

cmlara’s picture

cmlara
he/him
commented
Assigned: Unassigned » cmlara

Bumping this back to the top of my queue to work on.

cmlara opened merge request !40

cmlara’s picture

cmlara
he/him
commented
Status: Active » Needs review

Realized I had a version for 8.x-3x sitting in my local repo. Rebased it and pushing it up as an MR to get the ball rolling.

cmlara’s picture

cmlara
he/him
commented
Status: Needs review » Patch (to be ported)

Committing the 3.x version, tagging for evaluating if 4.x will need this or if architecture changes have already solved this.

  • cmlara committed 8f0ad6ee on 8.x-3.x 
    Issue #3356781 by cmlara: Bucket validation does not call hooks