Problem/Motivation

This is a follow-up to #3206643: Project messaging channel in core (as experimental) to give users a way to access the announcements feed if the toolbar module is disabled.
The feed is accessible via the "/admin/announcements_feed" route, but that link is not displayed anywhere if the toolbar module is disabled.

Proposed resolution

Show the link in the following situations:
* The help text provided by the module.
* New link under the "/admin" route.

Remaining tasks

Provide MR.

User interface changes

New "Annoucements" link will appear when viewing the help page and also when going under "/admin".

API changes

None.

Data model changes

None.

Release notes snippet

Issue fork drupal-3356515

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

fjgarlin created an issue. See original summary.

fjgarlin’s picture

Component: other » announcements_feed.module
Status: Postponed » Active
fjgarlin’s picture

Issue summary: View changes

fjgarlin’s picture

Status: Active » Needs review
StatusFileSize
new112.41 KB

Ready to review.

Enable the module, then navigate to "/admin", and you should see something like this if you have toolbar enabled:
Screenshot

If the toolbar module is disabled, you can still see the link and access notifications.

If you navigate to the "/admin/help" page, and then click on "Announcements" (/admin/help/announcements_feed), you will also see a link to the announcements page.

smustgrave’s picture

Status: Needs review » Needs work
Issue tags: +Needs Review Queue Initiative, +Needs issue summary update

Wonder if the IS could be updated if a solution.

Tried testing the patch and if the solution to add a link to the Structure page I did not see the link. Cleared cache several times

And when toolbar module is enabled I'm not seeing Announcements twice in the toolbar. Think that could be confusing.

fjgarlin’s picture

Issue summary: View changes
fjgarlin’s picture

Status: Needs work » Needs review

I updated the IS with the solution that this MR provides.

Tried testing the patch and if the solution is to add a link to the Structure page I did not see the link. Cleared cache several times

It was never under the "Structure" page, it was, and it still is, under the "/admin" page. I tried to think about arguments to add it inside the "Content", "Structure" or "Configuration" menu, but this is none of those really, so a link under the "Administration" page seems appropriate.

And when toolbar module is enabled I'm now seeing Announcements twice in the toolbar. Think that could be confusing.

That has been addressed now. It's shown only once.

--

With this MR, the help text provides a link to access the announcements page directly and it also shows a link under the "/admin" and "/admin/index" pages to access the announcements.

varun verma’s picture

StatusFileSize
new771.24 KB

I have review that, when toolbar module is enabled then Announcements showing once only. screenshot attached for reference.

smustgrave’s picture

Status: Needs review » Reviewed & tested by the community
Issue tags: -Needs issue summary update

Thanks for the issue summary update.

Tested again when the toolbar module is disabled the link does appear under
/admin technically it appears with or without the toolbar module I should say.

Version: 10.1.x-dev » 11.x-dev

Drupal core is moving towards using a “main” branch. As an interim step, a new 11.x branch has been opened, as Drupal.org infrastructure cannot currently fully support a branch named main. New developments and disruptive changes should now be targeted for the 11.x branch, which currently accepts only minor-version allowed changes. For more information, see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

  • longwave committed 611cda61 on 10.1.x
    Issue #3356515 by fjgarlin, varun verma, smustgrave: Give users a way to...

  • longwave committed 8b92bea8 on 11.x
    Issue #3356515 by fjgarlin, varun verma, smustgrave: Give users a way to...
longwave’s picture

Status: Reviewed & tested by the community » Fixed

Discussed with @lauriii and @catch, given that this makes the new module more usable without toolbar being installed we agreed to backport to 10.1.x.

Committed and pushed 8b92bea8c7 to 11.x (10.2.x) and 611cda6107 to 10.1.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.