Problem/Motivation
Seems that we are setting the request twice in MediaLibraryUiBuilder::buildMediaLibraryView():
// Make sure the state parameters are set in the request so the view can
// pass the parameters along in the pager, filters etc.
$view_request = $view_executable->getRequest();
$view_request->query->add($state->all());
$view_executable->setRequest($view_request);
$args = [$state->getSelectedTypeId()];
// Make sure the state parameters are set in the request so the view can
// pass the parameters along in the pager, filters etc.
$request = $view_executable->getRequest();
$request->query->add($state->all());
$view_executable->setRequest($request);
Steps to reproduce
N/A
Proposed resolution
Remove duplicate code.
Remaining tasks
N/A
User interface changes
None
API changes
None
Data model changes
None
Release notes snippet
N/A
Issue fork drupal-3356093
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
Comments
Comment #3
claudiu.cristeaComment #4
smustgrave commentedYup seems to be doing the same thing with different variables.
Comment #6
catchCommitted d4f3073 and pushed to 10.1.x. Thanks!