Problem/Motivation

Fix the error when displaying the disassociate form for an OpenStack Floating ip with no Instance ID set.

Issue fork cloud-3355515

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

sekinet created an issue. See original summary.

sekinet opened merge request !1734

sekinet opened merge request !1735

sekinet’s picture

sekinet commented
Status: Active » Needs review

@yas

Could you please review the patch?

Note that I created the patch for the 6.x branch by mistake, sorry, please disregard it. Thanks.

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Title: Fix the error when displaying the disassociate form for an OpenStack Floating ip with no Instance ID set » Fix an error when displaying the disassociate form for an OpenStack Floating ip with no Instance ID set
Status: Needs review » Needs work

@sekinet

Thank you for the fix. It looks good to me. I posted my comments. Thanks!

yas closed merge request !1735

sekinet’s picture

sekinet commented
Status: Needs work » Needs review

@yas

Thank you for your review. I fixed, could you please check it?

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Title: Fix an error when displaying the disassociate form for an OpenStack Floating ip with no Instance ID set » Fix an error when displaying the disassociate form for an OpenStack Floating IP with no Instance ID set
Status: Needs review » Needs work

@sekinet

Thank you for the update. I left my question, not asking the update. Thanks!

sekinet’s picture

sekinet commented
Status: Needs work » Needs review

@yas

Thank you for the confirmation, I fixed it from awsCloudOperationsService to openStackOperationsService and confirmed that it works.

Thanks!

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Needs review » Reviewed & tested by the community

@sekinet

Thank you for the update. It looks good to me now. I'll merge the patch to 4.x, 5.x and 6.x, and close this issue as Fixed.

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Title: Fix an error when displaying the disassociate form for an OpenStack Floating IP with no Instance ID set » Fix an error when displaying the disassociate form for an OpenStack Floating IP with no Instance ID

  • yas committed 14858c93 on 6.x authored by sekinet 
    Issue #3355515 by sekinet, yas: Fix an error when displaying the...

  • yas committed 83b7733f on 5.x authored by sekinet 
    Issue #3355515 by sekinet, yas: Fix an error when displaying the...

  • yas committed 538fae56 on 4.x authored by sekinet 
    Issue #3355515 by sekinet, yas: Fix an error when displaying the...
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.