Problem/Motivation

Hello, if the destination address does not start with '/' '?' '#' you will get an error:
Failed to authenticate user. Exception: The user-entered string 'home' must begin with a '/', '?', or '#'.

Proposed resolution

I think that an incorrect destination address should not affect the login result.
Remove unnecessary processing of the destination address with Url::fromUserInut().

Destination address without '/' '?' '#' is also considered valid and is processed by the kernel. For example, if you remove the slash from the destination in the login form, nothing will break and you will be redirected.

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

kay64 created an issue. See original summary.

kksandr’s picture

Status: Active » Needs review
keshavv’s picture

Status: Needs review » Reviewed & tested by the community

Reviewed the MR Looks good. Moving to RTBC

  • wells committed 262a8cb3 on 4.0.x authored by kksandr
    Issue #3355379: Crash if destination is invalid
    
wells’s picture

Status: Reviewed & tested by the community » Fixed

Looks good. Thanks for the fix!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.