config value use_default_styles is always executed as TRUE, so the default CSS is always loaded
Install Cookies module
- go to /admin/config/system/cookies/config
- uncheck checkbox Styling --> Use default styles
- save and clear cache
- check if browser stops loading file /libraries/cookiesjsr/dist/cookiesjsr.min.css
Fix getter of cookies.config.use-default_styles - see patch
| Comment | File | Size | Author |
|---|
Show commandsStart within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
changes
Comments
Comment #2
jiskra commentedComment #3
anybodyThanks @Jiskra - could you please provide a MR instead of a patch and keep the dependency injection ($this->configFactory)?
Comment #6
j-leeOpened the MR
Comment #7
anybodyThank you @J-Lee! MR looks good, now we need someone to test it or even better add a simple test case for this to ensure it works in the future.
Comment #8
j-leeWorking on the tests
Comment #9
grevil commentedTests are failing.
Comment #10
j-leeI have problems with the local test environment and a chmod permission problem, so I will test here.
Comment #11
anybodyOff-topic: @Jiskra you may want to try https://github.com/webksde/ddev-vscode-devcontainer-drupal9-template
Batteries and testing included with just two commands ;)
Comment #12
grevil commented@Anybody, I think you meant @J-Lee?
Still one test fails, see https://git.drupalcode.org/issue/cookies-3353972/-/jobs/120727.
Comment #13
j-leeI think I fixed the new tests for the default stylesheet behavior.
As a followup, perhaps a test base class could be created to better organize the tests.
Sorry for the long wait but I had to fix my dev environment first. Thanks @Anybody for the link.
Comment #14
j-leeComment #15
grevil commentedAlright, just some small additions. LGTM!
Comment #17
grevil commentedThere is a test base class for functional js tests, btw! But yea, I agree, that one for normal functional tests could be beneficial!
Comment #18
anybody