Problem/Motivation

With https://www.drupal.org/project/consumers/issues/3310801 we made the 'client_id' field available on the Consumer entity, it's also being used in SimpleOauthAuthenticationProvider, which sets the client_id value on the X-Consumer-ID header. But the consumer Negotiator is still assuming it's the uuid instead of the client_id.

Initial issue reported: https://www.drupal.org/project/simple_oauth/issues/3343744

Proposed resolution

Update the Negotiator to load the consumer entity by client_id.

Issue fork consumers-3348681

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

bojan_dev created an issue. See original summary.

bojan_dev opened merge request !7

bojan_dev’s picture

bojan_dev commented
Status: Active » Needs review

eojthebrave made their first commit to this issue’s fork.

eojthebrave’s picture

eojthebrave
he/him
Primary language English
Location Minneapolis, MN
commented
Status: Needs review » Fixed

The code here looks good. And because in #3310801: Add client_id field to the consumer entity we already provided an update hook that populates the client_id field with the consumer UUID this is just fixing a bug and doesn't require any kind of data update. So ... looks good to me. Thanks @bojan_dev. I'll work on getting a new release out ASAP.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.