Problem/Motivation

Sometimes we want to create custom responses using Custom Elements. Therefore it would be nice to be able to let the CustomElementRenderer render the content only in the right format without creating the complete response object.

Steps to reproduce

Proposed resolution

  • Create new methods in CustomElementRenderer that take care of rendering the custom element content only.
  • Introduce a new CustomElementRendererTrait for easier usage of the renderer.

Remaining tasks

User interface changes

API changes

Additional methods on CustomElementRenderer

Data model changes

CommentFileSizeAuthor
#7 3348108-7--render-custom-elements.patch8.54 KBarthur_lorenz
#6 3348108-6--render-custom-elements.patch6.22 KBarthur_lorenz

Issue fork lupus_ce_renderer-3348108

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

arthur_lorenz created an issue. See original summary.

arthur_lorenz opened merge request !29

arthur_lorenz’s picture

arthur_lorenz commented
Title: With CustomElementsRenderer we should also be able to render a CustomElement's content only. » 3348108-customelementsrenderer
Status: Active » Needs review
arthur_lorenz’s picture

arthur_lorenz commented
Title: 3348108-customelementsrenderer » Allow to render custom element content only
fago’s picture

fago
Primary language German
Location Vienna
commented
Status: Needs review » Needs work
arthur_lorenz’s picture

arthur_lorenz commented
Status: Needs work » Needs review
StatusFileSize
new 3348108-6--render-custom-elements.patch6.22 KB

Thx, updated MR and additionally uploaded a patch file.

arthur_lorenz’s picture

arthur_lorenz commented
StatusFileSize
new 3348108-7--render-custom-elements.patch8.54 KB

Thx improved naming and code docs.

  • fago committed 0ec7c7f3 on 2.x authored by arthur_lorenz 
    Issue #3348108 by arthur_lorenz: Add API to render custom elements based...
fago’s picture

fago
Primary language German
Location Vienna
commented
Status: Needs review » Fixed

This works well and is a good improvement, so merged.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.