Problem/Motivation

When editing a node with ckeditor bidi button set to RTL, the RTL gets unset only for the first paragraph.

Steps to reproduce

  1. On a fresh D10 site, install and enable the latest ckeditor_bidi module (as of now that would be 4.x)
  2. Go to edit the text formats / editors at [site.domain]/admin/config/content/formats
  3. Add the "BiDi" button to the editor toolbar
  4. On the plugin configuration, set the "RTL" option to be the Default
  5. Go create a new node
  6. Add more than one paragraph
  7. Make sure all paragraphs have their "dir" set to RTL
  8. Save changes
  9. Viewing the node, see how all the paragraphs have the correct "dir"
  10. Go edit that same node
  11. Note how the first paragraph has lost the RTL dir, while the others still have it

If you make any change to the node, and save it, the first paragraph (that previously had <p dir="rtl">) will lose the direction

Remaining tasks

Add tests?

Attaching here a screencast showing the bug.

CommentFileSizeAuthor
bidi4_ckeditor5_edit_issues.mp44.82 MBanairamzap

Issue fork ckeditor_bidi-3346808

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

anairamzap created an issue. See original summary.

rajab natshah’s picture

rajab natshah
he/him
commented

Facing the same issue
In RTL I can not switch a paragraph to LTR

smustgrave made their first commit to this issue’s fork.

smustgrave opened merge request !8

smustgrave’s picture

smustgrave commented
Status: Active » Needs review

Ckeditor5 is not my strongest but give this a shot.

  • smustgrave committed 8ff22436 on 4.0.x 
    Issue #3346808: On node edit, the RTL gets unset only for the first...
smustgrave’s picture

smustgrave commented
Status: Needs review » Fixed

From my testing believe this has been fixed.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.