Problem/Motivation
This module is not yet Drupal 10 compatible. I've added a patch to make it compatible with Drupal 10.
The errors
CUSTOM PROJECTS
--------------------------------------------------------------------------------
BSN
Scanned on Wed, 03/08/2023 - 10:38.
4 errors found. 1 warning found. Avoid some manual work by using drupal-rector
for fixing issues automatically or Upgrade Rector to generate patches.
web/modules/custom/bsn_field/tests/src/Kernel/BSNItemTest.php:
┌──────────┬──────┬─────────────────────────────────────────────────────┐
│ STATUS │ LINE │ MESSAGE │
├──────────┼──────┼─────────────────────────────────────────────────────┤
│ Fix with │ 62 │ Call to deprecated method assertEqual() of class │
│ rector │ │ Drupal\KernelTests\KernelTestBase. Deprecated in │
│ │ │ drupal:8.0.0 and is removed from drupal:10.0.0. Use │
│ │ │ $this->assertEquals() instead. │
│ │ │ │
│ Fix with │ 63 │ Call to deprecated method assertEqual() of class │
│ rector │ │ Drupal\KernelTests\KernelTestBase. Deprecated in │
│ │ │ drupal:8.0.0 and is removed from drupal:10.0.0. Use │
│ │ │ $this->assertEquals() instead. │
│ │ │ │
│ Fix with │ 68 │ Call to deprecated method assertEqual() of class │
│ rector │ │ Drupal\KernelTests\KernelTestBase. Deprecated in │
│ │ │ drupal:8.0.0 and is removed from drupal:10.0.0. Use │
│ │ │ $this->assertEquals() instead. │
│ │ │ │
│ Fix with │ 73 │ Call to deprecated method assertEqual() of class │
│ rector │ │ Drupal\KernelTests\KernelTestBase. Deprecated in │
│ │ │ drupal:8.0.0 and is removed from drupal:10.0.0. Use │
│ │ │ $this->assertEquals() instead. │
│ │ │ │
└──────────┴──────┴─────────────────────────────────────────────────────┘
web/modules/custom/bsn_field/bsn_field.info.yml:
┌──────────┬──────┬────────────────────────────────────────────────────────────┐
│ STATUS │ LINE │ MESSAGE │
├──────────┼──────┼────────────────────────────────────────────────────────────┤
│ Check │ 0 │ Value of core_version_requirement: ^8 || ^9 is not │
│ manually │ │ compatible with the next major version of Drupal core. See │
│ │ │ https://drupal.org/node/3070687. │
│ │ │ │
└──────────┴──────┴────────────────────────────────────────────────────────────┘
| Comment | File | Size | Author |
|---|---|---|---|
| #7 | remove-core-key-info-file-3346696-7.patch | 330 bytes | ralphvdhoudt |
| #3 | 3346696-3-bsn_field-d10-compatibility.patch | 1.57 KB | johankleene |
| drupal-10-compatibility.patch | 1.96 KB | johan_vm |
Comments
Comment #2
johan_vm commentedComment #3
johankleene commentedAdditionally fixed the tests signature, because the tests were not running and renamed tests.
Comment #5
joshahubbers commentedComitted
Comment #6
ralphvdhoudt commentedComment #7
ralphvdhoudt commentedFix The 'core_version_requirement' constraint (^9 || ^10) requires the 'core' key not be set in bsn_field/bsn_field.info.yml
Comment #9
ralphvdhoudt commented