Problem/Motivation

This module is not yet Drupal 10 compatible. I've added a patch to make it compatible with Drupal 10.

The errors

CUSTOM PROJECTS
--------------------------------------------------------------------------------
BSN
Scanned on Wed, 03/08/2023 - 10:38.

4 errors found. 1 warning found. Avoid some manual work by using drupal-rector
for fixing issues automatically or Upgrade Rector to generate patches.

web/modules/custom/bsn_field/tests/src/Kernel/BSNItemTest.php:
┌──────────┬──────┬─────────────────────────────────────────────────────┐
│  STATUS  │ LINE │                       MESSAGE                       │
├──────────┼──────┼─────────────────────────────────────────────────────┤
│ Fix with │ 62   │ Call to deprecated method assertEqual() of class    │
│ rector   │      │ Drupal\KernelTests\KernelTestBase. Deprecated in    │
│          │      │ drupal:8.0.0 and is removed from drupal:10.0.0. Use │
│          │      │ $this->assertEquals() instead.                      │
│          │      │                                                     │
│ Fix with │ 63   │ Call to deprecated method assertEqual() of class    │
│ rector   │      │ Drupal\KernelTests\KernelTestBase. Deprecated in    │
│          │      │ drupal:8.0.0 and is removed from drupal:10.0.0. Use │
│          │      │ $this->assertEquals() instead.                      │
│          │      │                                                     │
│ Fix with │ 68   │ Call to deprecated method assertEqual() of class    │
│ rector   │      │ Drupal\KernelTests\KernelTestBase. Deprecated in    │
│          │      │ drupal:8.0.0 and is removed from drupal:10.0.0. Use │
│          │      │ $this->assertEquals() instead.                      │
│          │      │                                                     │
│ Fix with │ 73   │ Call to deprecated method assertEqual() of class    │
│ rector   │      │ Drupal\KernelTests\KernelTestBase. Deprecated in    │
│          │      │ drupal:8.0.0 and is removed from drupal:10.0.0. Use │
│          │      │ $this->assertEquals() instead.                      │
│          │      │                                                     │
└──────────┴──────┴─────────────────────────────────────────────────────┘

web/modules/custom/bsn_field/bsn_field.info.yml:
┌──────────┬──────┬────────────────────────────────────────────────────────────┐
│  STATUS  │ LINE │                          MESSAGE                           │
├──────────┼──────┼────────────────────────────────────────────────────────────┤
│ Check    │ 0    │ Value of core_version_requirement: ^8 || ^9 is not         │
│ manually │      │ compatible with the next major version of Drupal core. See │
│          │      │ https://drupal.org/node/3070687.                           │
│          │      │                                                            │
└──────────┴──────┴────────────────────────────────────────────────────────────┘

Comments

johan_vm created an issue. See original summary.

johan_vm’s picture

Status: Active » Needs review
johankleene’s picture

Additionally fixed the tests signature, because the tests were not running and renamed tests.

  • JohanKleene authored 064388bf on 8.x-1.x
    Issue #3346696 by johan_vm, JohanKleene: Drupal 10 Compatibility
    
joshahubbers’s picture

Status: Needs review » Fixed

Comitted

ralphvdhoudt’s picture

Status: Fixed » Needs work
ralphvdhoudt’s picture

Status: Needs work » Needs review
StatusFileSize
new330 bytes

Fix The 'core_version_requirement' constraint (^9 || ^10) requires the 'core' key not be set in bsn_field/bsn_field.info.yml

  • ralphvdhoudt committed 95e15a8f on 8.x-1.x
    Issue #3346696 by johan_vm, ralphvdhoudt, JohanKleene: Drupal 10...
ralphvdhoudt’s picture

Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.