Problem/Motivation

Upgrade module to work on Drupal 10.

Steps to reproduce

Install this module and run upgrade status report.

Proposed resolution

Update core_version_requirements in info.yml to ^8 || ^9 || ^10

CommentFileSizeAuthor
#7 guzzle_cache_d10-3345622-7.patch2.52 KBm4olivei
#3 MR branch.PNG10.79 KBabhinavk
#3 upgrade_status_msg.PNG8.49 KBabhinavk
#3 guzzle_cache_drupal-check.txt2.71 KBabhinavk
#3 interdiff-2-3.txt2.56 KBabhinavk
#3 guzzle_cache_d10-3345622-3.patch2.92 KBabhinavk

Issue fork guzzle_cache-3345622

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

michael-portable created an issue. See original summary.

michael-portable opened merge request !2

abhinavk’s picture

abhinavk commented
Status: Active » Needs review
StatusFileSize
new guzzle_cache_d10-3345622-3.patch2.92 KB
new interdiff-2-3.txt2.56 KB
new guzzle_cache_drupal-check.txt2.71 KB
new upgrade_status_msg.PNG8.49 KB
new MR branch.PNG10.79 KB

I checked MR !2 in my local and got Upgrade status error. I have resolved that error and also resolved most of drupal-check errors.

While running tests in local I found 1 issue related to prefix length which I have fixed.

I am uploading upgrade status error, drupal check errors and updated patch.

Please review the patch.

rahul17’s picture

rahul17 commented
Status: Needs review » Reviewed & tested by the community

I have tested patch #3 in Drupal 9.5.7 and 10.0.7 and PHP 8.1. Patch applied cleanly and makes this module d10 compatible. Functionality is working as expected.
Checked with drupal check and upgrade status which gives no errors.
Hence, moving this to RTBC for d10 stable release.

deviantintegral’s picture

deviantintegral commented
Status: Reviewed & tested by the community » Needs review
deviantintegral’s picture

deviantintegral commented

Looks like tests weren't configured to run on the 3.x branch. I just turned that on, let's see if that kicks off. Otherwise, this looks good. Thank you!

m4olivei’s picture

m4olivei
he/him
Primary language English
Location Grimsby, ON
commented
StatusFileSize
new guzzle_cache_d10-3345622-7.patch2.52 KB

Patch re-roll on latest 3.x. I also set back the test param.

  • m4olivei committed 8379c21e on 3.x 
    Issue #3345622 by michael-portable, AbhinavK, m4olivei, deviantintegral...
m4olivei’s picture

m4olivei
he/him
Primary language English
Location Grimsby, ON
commented
Version: 3.0.0 » 3.x-dev
Assigned: » Unassigned
Status: Needs review » Fixed

Commited to 3.x! Thanks all.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.