Problem/Motivation

Getting following warning.

FILE: /var/www/html/modules/contrib/group_term/src/Plugin/Group/RelationHandler/GroupTermOperationProvider.php
--------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
--------------------------------------------------------------------------------------------------------------
42 | WARNING | Vocabulary::load calls should be avoided in classes, use dependency injection instead
--------------------------------------------------------------------------------------------------------------

Time: 2.48 secs; Memory: 6MB

Steps to reproduce

Run following command

phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml modules/contrib/group_term/

Proposed resolution

Above warning need to be fixed.

CommentFileSizeAuthor
#2 3345381-2.patch3.28 KBsamitk

Issue fork group_term-3345381

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

samit.310@gmail.com created an issue. See original summary.

samitk’s picture

samitk commented
Assigned: samitk » Unassigned
Status: Needs work » Needs review
StatusFileSize
new 3345381-2.patch3.28 KB

Above warning has been fixed.

omkar_yewale’s picture

omkar_yewale commented
Assigned: Unassigned » omkar_yewale

omkar_yewale opened merge request !7

omkar_yewale’s picture

omkar_yewale commented
Assigned: omkar_yewale » Unassigned

!7 A MR has been created for easy review.

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Title: Drupal Coding Standards Issues | phpcs » Fix the issues reported by phpcs
Priority: Normal » Minor
Issue tags: -Coding standards Phpcs, -Phpcs Drupal coding standard issue

LOBsTerr made their first commit to this issue’s fork.

lobsterr’s picture

lobsterr commented
Status: Needs review » Fixed

Thank you for contribution

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.