Problem/Motivation
There are a number of PHPCS issues being reported during automated tests.
Proposed resolution
Resolve outstanding PHPCS issues.
| Comment | File | Size | Author |
|---|---|---|---|
| #24 | 3344114-24.patch | 1.25 KB | mrinalini9 |
| #21 | 3344114-21.patch | 1.31 KB | imustakim |
| #18 | 3344114-12.patch | 3.69 KB | himanshu_jhaloya |
| #14 | after-applied-patch.png | 34.13 KB | himanshu_jhaloya |
| #11 | interdiff_9-11.txt | 2.94 KB | akram khan |
Issue fork csv_serialization-3344114
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
Comments
Comment #3
markdorisonComment #4
nayana_mvr commentedVerified MR!17. Except the following issues, all other errors are fixed:
Comment #7
avpadernoComment #8
imustakim commentedWorking on this.
Comment #9
imustakim commentedAdded a patch.
Comment #10
akram khanafter applying patch 9 still issues are there.
phpcs --standard="Drupal,DrupalPractice" --extensions=php,module,inc,install,test,profile,theme,info,txt,md,yml /Users/akram.khan/Desktop/Contribution/drupal10.1/drupal/modules/contrib/csv_serialization/
FILE: ...n/drupal10.1/drupal/modules/contrib/csv_serialization/csv_serialization.install
-------------------------------------------------------------------------------------
FOUND 5 ERRORS AND 2 WARNINGS AFFECTING 4 LINES
-------------------------------------------------------------------------------------
1 | ERROR | [x] Missing file doc comment
5 | ERROR | [ ] Missing short description in doc comment
12 | WARNING | [ ] Hook implementations should not duplicate @param documentation
12 | ERROR | [ ] Missing parameter comment
12 | ERROR | [ ] Missing parameter type
14 | WARNING | [ ] Hook implementations should not duplicate @return documentation
14 | ERROR | [ ] Description for the @return value is missing
-------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-------------------------------------------------------------------------------------
FILE: .../drupal10.1/drupal/modules/contrib/csv_serialization/src/Encoder/CsvEncoder.php
-------------------------------------------------------------------------------------
FOUND 9 ERRORS AND 1 WARNING AFFECTING 10 LINES
-------------------------------------------------------------------------------------
5 | ERROR | [x] Non-namespaced classes/interfaces/traits should not be
| | referenced with use statements
10 | ERROR | [x] Non-namespaced classes/interfaces/traits should not be
| | referenced with use statements
14 | WARNING | [x] Unused use statement
258 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 6
259 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 6
260 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 8
261 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 6
263 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 6
290 | ERROR | [ ] Description for the @return value is missing
389 | ERROR | [x] Use null coalesce operator instead of ternary operator.
-------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 9 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-------------------------------------------------------------------------------------
Comment #11
akram khanadded updated patch it's remove remaining error
Comment #12
akram khanComment #13
himanshu_jhaloya commentedComment #14
himanshu_jhaloya commented#12 Patch applied cleanly no error&warning Found , Moving to RTBC
Comment #15
himanshu_jhaloya commentedComment #16
avpadernoThat is not how documentation comments are correct. Description message needs to be replaced with a true description message.
Comment #17
avpadernoIt would also be better to show which tool has been used for checking the code, which parameters have been used, and which report has been produced by that tool.
Comment #18
himanshu_jhaloya commentedCreated the patch update the comment please review
Comment #19
avpadernoThe comment for a .install file is different. It does not report the module dependencies.
The previous patch changed two of those comments, but the latest one just changes one of them.
It should be decoded.
Comment #20
imustakim commentedComment #21
imustakim commentedPatch updated.
Please review.
Comment #22
imustakim commentedComment #23
avpadernoComment #24
mrinalini9 commentedRerolled patch #21, please review it.
Thanks!
Comment #26
markdorisonIn the future, if an issue has been started with a merge request, I encourage you to stick with that instead of switching to using patch files.