Problem/Motivation

As documented in commerce module, onNotify method should never throw exceptions and should always acknowledge receiving the notification; currently 2c2p keeps sending notification requests if the payment failed.

Attached a patch that keeps throwing PaymentGatewayException and logging it but catches it and returns 200 response code.
In addition, I added a check for the order state before creating the payment similar to what we have in onReturn method.

CommentFileSizeAuthor
catch-exceptions.patch1.28 KBredwan jamous

Comments

RedwanJamous created an issue. See original summary.

  • e0319921 committed on 1.0.x
    Issue #3343420 by Redwan Jamous: Always respond to 2c2p notification...
josebc’s picture

Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.