Problem/Motivation

FILE: /Users/sahil.goyal/Documents/MySites/10.1.x/drupal/modules/contrib/groupmedia/tests/src/Functional/EntityOperationsTest.php
---------------------------------------------------------------------------------------------------------------------------------
FOUND 6 ERRORS AND 1 WARNING AFFECTING 5 LINES
---------------------------------------------------------------------------------------------------------------------------------
 65 | ERROR   | [ ] Parameter tags must be defined first in a doc comment
 65 | ERROR   | [ ] Missing parameter type
 67 | ERROR   | [ ] Missing parameter type
 78 | ERROR   | [ ] Type hint "array" missing for $permissions
 78 | ERROR   | [ ] Type hint "array" missing for $modules
 86 | ERROR   | [x] There should be no white space after an opening "("
 94 | WARNING | [ ] Unused variable $group.
---------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
---------------------------------------------------------------------------------------------------------------------------------


FILE: /Users/sahil.goyal/Documents/MySites/10.1.x/drupal/modules/contrib/groupmedia/tests/src/Kernel/GroupMediaConfigTest.php
-----------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
-----------------------------------------------------------------------------------------------------------------------------
 27 | WARNING | [x] A comma should follow the last multiline array item. Found: 'views'
-----------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-----------------------------------------------------------------------------------------------------------------------------


FILE: /Users/sahil.goyal/Documents/MySites/10.1.x/drupal/modules/contrib/groupmedia/groupmedia.module
-----------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES
-----------------------------------------------------------------------------------------------------
  14 | WARNING | [x] Unused use statement
 107 | WARNING | [ ] Line exceeds 80 characters; contains 82 characters
-----------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-----------------------------------------------------------------------------------------------------


FILE: /Users/sahil.goyal/Documents/MySites/10.1.x/drupal/modules/contrib/groupmedia/modules/groupmedia_paragraphs/groupmedia_paragraphs.module
----------------------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
----------------------------------------------------------------------------------------------------------------------------------------------
 37 | WARNING | [x] '@TODO: Fix when the parent paragraph was not yet saved.' should match the format '@todo Fix problem X here.'
----------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------------------------------------------------------------------------------


FILE: /Users/sahil.goyal/Documents/MySites/10.1.x/drupal/modules/contrib/groupmedia/modules/groupmedia_vbo/src/Plugin/Action/RemoveMediaFromGroup.php
-----------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-----------------------------------------------------------------------------------------------------------------------------------------------------
 77 | ERROR | [x] Expected 1 blank line after function; 0 found
-----------------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-----------------------------------------------------------------------------------------------------------------------------------------------------


FILE: /Users/sahil.goyal/Documents/MySites/10.1.x/drupal/modules/contrib/groupmedia/src/Form/GroupMediaSettingsForm.php
-----------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
-----------------------------------------------------------------------------------------------------------------------
 15 | WARNING | The class short comment should describe what the class does and not simply repeat the class name
-----------------------------------------------------------------------------------------------------------------------


FILE: /Users/sahil.goyal/Documents/MySites/10.1.x/drupal/modules/contrib/groupmedia/src/Plugin/Group/Relation/GroupMediaDeriver.php
-----------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
-----------------------------------------------------------------------------------------------------------------------------------
 14 | WARNING | The class short comment should describe what the class does and not simply repeat the class name
-----------------------------------------------------------------------------------------------------------------------------------


FILE: /Users/sahil.goyal/Documents/MySites/10.1.x/drupal/modules/contrib/groupmedia/src/Plugin/Group/RelationHandler/GroupMediaOperationProvider.php
----------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES
----------------------------------------------------------------------------------------------------------------------------------------------------
 42 | WARNING | [ ] MediaType::load calls should be avoided in classes, use dependency injection instead
 49 | WARNING | [x] A comma should follow the last multiline array item. Found: pluginId
----------------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------------------------------------------------------------------------------------


FILE: /Users/sahil.goyal/Documents/MySites/10.1.x/drupal/modules/contrib/groupmedia/src/Plugin/MediaFinder/TextFieldEmbedBase.php
---------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES
---------------------------------------------------------------------------------------------------------------------------------
 15 | WARNING | The class short comment should describe what the class does and not simply repeat the class name
 83 | WARNING | Line exceeds 80 characters; contains 81 characters
---------------------------------------------------------------------------------------------------------------------------------


FILE: /Users/sahil.goyal/Documents/MySites/10.1.x/drupal/modules/contrib/groupmedia/src/Plugin/MediaFinder/MediaReference.php
-----------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
-----------------------------------------------------------------------------------------------------------------------------
 29 | WARNING | Line exceeds 80 characters; contains 81 characters
-----------------------------------------------------------------------------------------------------------------------------


FILE: /Users/sahil.goyal/Documents/MySites/10.1.x/drupal/modules/contrib/groupmedia/src/Plugin/MediaFinder/MediaFinderBase.php
------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
------------------------------------------------------------------------------------------------------------------------------
 18 | WARNING | The class short comment should describe what the class does and not simply repeat the class name
------------------------------------------------------------------------------------------------------------------------------


FILE: /Users/sahil.goyal/Documents/MySites/10.1.x/drupal/modules/contrib/groupmedia/src/Plugin/Action/RemoveMediaFromGroup.php
------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
------------------------------------------------------------------------------------------------------------------------------
 76 | ERROR | [x] Expected 1 blank line after function; 0 found
------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------------------------------------------------------


FILE: /Users/sahil.goyal/Documents/MySites/10.1.x/drupal/modules/contrib/groupmedia/src/AttachMediaToGroup.php
----------------------------------------------------------------------------------------------------------------------
FOUND 6 ERRORS AND 1 WARNING AFFECTING 7 LINES
----------------------------------------------------------------------------------------------------------------------
  21 | WARNING | [ ] The class short comment should describe what the class does and not simply repeat the class name
 124 | ERROR   | [x] Expected 1 spaces after parameter type; 9 found
 126 | ERROR   | [x] Expected 1 spaces after parameter type; 2 found
 128 | ERROR   | [x] Expected 1 spaces after parameter type; 35 found
 193 | ERROR   | [x] Expected newline after closing brace
 196 | ERROR   | [x] Expected newline after closing brace
 247 | ERROR   | [x] Expected 1 space after closing parenthesis; found 0
----------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 6 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------------------------------------------------------


FILE: /Users/sahil.goyal/Documents/MySites/10.1.x/drupal/modules/contrib/groupmedia/src/MediaFinderInterface.php
-----------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
-----------------------------------------------------------------------------------------------------------------
 12 | WARNING | The class short comment should describe what the class does and not simply repeat the class name
-----------------------------------------------------------------------------------------------------------------

Time: 291ms; Memory: 10MB

Steps to reproduce

Run the following command : phpcs --standard="Drupal,DrupalPractice" --extensions=php,module,inc,install,test,profile,theme,info,txt,md,yml /10.1.x/drupal/modules/contrib/groupmedia

Proposed resolution

Fix all the PHP Coding standard Issues.

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#4 Screenshot 2023-02-16 at 11.10.26 AM.png1.43 MBspriya2896
#2 3342229-2.patch13.54 KBsahil.goyal

Issue fork groupmedia-3342229

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

sahil.goyal created an issue. See original summary.

sahil.goyal’s picture

sahil.goyal commented
Status: Needs work » Needs review
StatusFileSize
new 3342229-2.patch13.54 KB

Updating the patch to resolve all php coding standards issues and warnings. Please Review.

spriya2896’s picture

spriya2896 commented
Assigned: Unassigned » spriya2896

I will review this patch.

spriya2896’s picture

spriya2896 commented
Assigned: spriya2896 » Unassigned
Status: Needs review » Needs work
StatusFileSize
new Screenshot 2023-02-16 at 11.10.26 AM.png1.43 MB

This patch failed to apply.

annmarysruthy’s picture

annmarysruthy commented
Assigned: Unassigned » annmarysruthy

annmarysruthy opened merge request !22

annmarysruthy’s picture

annmarysruthy commented
Assigned: annmarysruthy » Unassigned
Status: Needs work » Needs review

Created an MR for fixing the issue. please review.

annmarysruthy opened merge request !24

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Title: Drupal Coding Standards Issues | phpcs » Fix the issues reported by phpcs
Category: Bug report » Task
Issue tags: -Drupal Coding Standards Issues | phpcs

  • LOBsTerr committed 56e3bcd1 on 8.x-2.x authored by sahil.goyal 
    Issue #3342229 by sahil.goyal, LOBsTerr: Fix the issues reported by...

lobsterr’s picture

lobsterr commented
Status: Needs review » Fixed

Thank you for your contribution

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.