Problem/Motivation

Dependency tree (order of the migration execution) might use less memory (and can use less computing resources) if there aren't any optional dependencies in the migration set: in this case, $required_dependency_graph is computed without any reason.

Proposed resolution

Optimize MigrationPluginManagerInterface::buildDependencyMigration().

CommentFileSizeAuthor
#6 smc-optimize_dependency_calculation-3340714-6.patch7.73 KBhuzooka
#5 interdiff-3340714-3-5.txt2.31 KBhuzooka
#5 smc-optimize_dependency_calculation-3340714-5.patch8.68 KBhuzooka
#3 smc-optimize_dependency_calculation-3340714-3.patch8.76 KBhuzooka
#2 smc-optimize_dependency_calculation-3340714-2.patch8.8 KBhuzooka

Comments

huzooka created an issue. See original summary.

huzooka’s picture

huzooka
Primary language Hungarian
Location Hungary 🇭🇺🇪🇺
commented
Status: Active » Needs review
StatusFileSize
new smc-optimize_dependency_calculation-3340714-2.patch8.8 KB
huzooka’s picture

huzooka
Primary language Hungarian
Location Hungary 🇭🇺🇪🇺
commented
StatusFileSize
new smc-optimize_dependency_calculation-3340714-3.patch8.76 KB

Status: Needs review » Needs work

The last submitted patch, 3: smc-optimize_dependency_calculation-3340714-3.patch, failed testing. View results

huzooka’s picture

huzooka
Primary language Hungarian
Location Hungary 🇭🇺🇪🇺
commented
Status: Needs work » Needs review
StatusFileSize
new smc-optimize_dependency_calculation-3340714-5.patch8.68 KB
new interdiff-3340714-3-5.txt2.31 KB
huzooka’s picture

huzooka
Primary language Hungarian
Location Hungary 🇭🇺🇪🇺
commented
StatusFileSize
new smc-optimize_dependency_calculation-3340714-6.patch7.73 KB

This patch is the rebased version of the one in #5.

  • huzooka committed 1f7855f6 on 1.0.x 
    Issue #3340714 by huzooka: Optimize dependency tree calculation
huzooka’s picture

huzooka
Primary language Hungarian
Location Hungary 🇭🇺🇪🇺
commented
Status: Needs review » Fixed
huzooka’s picture

huzooka
Primary language Hungarian
Location Hungary 🇭🇺🇪🇺
commented
Assigned: huzooka » Unassigned

Released in 1.0.0-alpha12.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.