Problem/Motivation

I get the following error uninstalling the submodule:

Error: Call to a member function delete() on null in /var/www/html/modules/contrib/gh_jobs/gh_jobs_migrate/gh_jobs_migrate.install on line 25 #0 [internal function]: gh_jobs_migrate_uninstall(false)

Steps to reproduce

  1. Install the migrate_plus and migrate_tools modules.
  2. Enable the gh_jobs_migrate module.
  3. Delete the gh_departments vocabulary.
  4. Uninstall the gh_jobs_migrate module.

Proposed resolution

In the implementation of hook_uninstall(), check for empty before deleting the configuration entities (content type and two vocabularies).

Remaining tasks

User interface changes

None

API changes

None

Data model changes

None

CommentFileSizeAuthor
#2 gh_jobs-3339674-2.patch1.57 KBbenjifisher

Comments

benjifisher created an issue. See original summary.

benjifisher’s picture

benjifisher
he/him or they/them
Primary language English
Location Boston area
commented
Assigned: benjifisher » Unassigned
Status: Active » Needs review
StatusFileSize
new gh_jobs-3339674-2.patch1.57 KB

The attached patch fixes the problem in my testing.

  • benjifisher committed a59a4fa7 on 8.x-1.x 
    Issue #3339674 by benjifisher: Errors uninstalling the gh_jobs_migrate...
benjifisher’s picture

benjifisher
he/him or they/them
Primary language English
Location Boston area
commented
Status: Needs review » Fixed

Better late than never: I committed the patch, so this issue is Fixed.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.