Problem/Motivation
The Date range facet does not go away when the dependent processor's conditions are not met.
Steps to reproduce
- two facets, "parent" and "dependent"
- set the "dependent" to appear on a certain value of the "parent"
- go to the view page (or whatever page uses the index)
- you should not see the dependent date range facet, but you do.
Proposed resolution
Add a check in the widget itself to check to processors again, this is done by the DefaultFacetManager BUT, that only empties the results, which is not compatible with our Date Range widget, so we need to re-check and use a bool as result.
| Comment | File | Size | Author |
|---|---|---|---|
| #9 | 3339509-9.patch | 4.42 KB | andras_szilagyi |
| #8 | 3339509_2.patch | 3.41 KB | tiberiu.dumitru23 |
| #6 | 3339509.patch | 2.87 KB | tiberiu.dumitru23 |
Issue fork facets_form-3339509
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
- 3339509-daterange-dependent
changes, plain diff MR !40
- 3339509-date-range--
compare
- 1.x
changes, plain diff MR !39
Comments
Comment #6
tiberiu.dumitru23 commentedUploading patch with just the test to see it fail
Comment #7
andras_szilagyi commentedPlease check, the patch is failing for the wrong reasons
Comment #8
tiberiu.dumitru23 commentedUploading new test file for current implementation.
Comment #9
andras_szilagyi commentedComment #10
andras_szilagyi commentedThe MR is ok and passes, and we can see the same test fail for the right reasons in the patch.
Comment #12
andras_szilagyi commented