Problem/Motivation

The Date range facet does not go away when the dependent processor's conditions are not met.

Steps to reproduce

- two facets, "parent" and "dependent"
- set the "dependent" to appear on a certain value of the "parent"
- go to the view page (or whatever page uses the index)
- you should not see the dependent date range facet, but you do.

Proposed resolution

Add a check in the widget itself to check to processors again, this is done by the DefaultFacetManager BUT, that only empties the results, which is not compatible with our Date Range widget, so we need to re-check and use a bool as result.

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

Andras_Szilagyi created an issue. See original summary.

tiberiu.dumitru23 made their first commit to this issue’s fork.

tiberiu.dumitru23’s picture

StatusFileSize
new2.87 KB

Uploading patch with just the test to see it fail

andras_szilagyi’s picture

Status: Active » Needs work

Please check, the patch is failing for the wrong reasons

tiberiu.dumitru23’s picture

StatusFileSize
new3.41 KB

Uploading new test file for current implementation.

andras_szilagyi’s picture

StatusFileSize
new4.42 KB
andras_szilagyi’s picture

The MR is ok and passes, and we can see the same test fail for the right reasons in the patch.

andras_szilagyi’s picture

Status: Needs work » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.