GitLab CI reports PHP_CodeSniffer errors/warnings which should be fixed.
| Comment | File | Size | Author |
|---|---|---|---|
| #2 | 3339496-2.patch | 19.92 KB | sahil.goyal |
Issue fork cer-3339496
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
Comments
Comment #2
sahil.goyal commentedFixing all the php coding standard issues and warnings in this patch. Please Review.
Comment #3
charchil khandelwal commentedI will review this.
Comment #5
charchil khandelwal commentedPatch #2 tested and applied successfully, all errors and warnings are fixed now.
Created MR !9 for this issue.
Please review.
Thanks.
Comment #6
avpadernoComment #7
avpadernoThe correct short description for those files is Describes hooks provided by the [module name] module.
The existing description is correct, except for a typo.
As per Drupal coding standards, function declarations are written in a single line.
The return value is not documented.
Parameters and return value descriptions are missing.
Comment #11
sakthi_dev commentedAddressed the comment #7. Please review.
Comment #12
a.aaronjake commentedHi @sakthi_dev,
Your changes on the MR !9 was applied not-so successfully and errors were reported. Please see below:
Kindly check
Thanks,
Jake
Comment #17
avpadernoComment #18
avpadernoMR !9 did not fix all the reported warnings/errors, contrarily to MR !16.
Comment #20
grevil commentedPHPCS doesn't complain any more. Thanks all!
Merging.
Comment #21
grevil commented