Problem/Motivation

The current code fails in PHP 8, which is needed for Drupal 10

Proposed resolution

First apply fixes from #3299455: Automated Drupal 10 compatibility fixes, then add fixes for php 8

Remaining tasks

Verify tests pass on Drupal 9.5 + php 7.4 or 8, plus Drupal 10 + php 8

CommentFileSizeAuthor
#8 3338660-8.patch4.14 KBpwolanin
#7 3338660-7.patch4.14 KBpwolanin
#5 3338660-5.patch3.85 KBpwolanin
#4 3338660-4.patch1.86 KBpwolanin
#2 views-streaming-data-php8.patch1.36 KBkdebisschop

Comments

pwolanin created an issue. See original summary.

kdebisschop’s picture

kdebisschop commented
StatusFileSize
new views-streaming-data-php8.patch1.36 KB

see https://www.php.net/releases/8.1/en.php

"Passing null to non-nullable internal function parameters is deprecated."

The signature for explode is:

explode(string $separator, string $string, int $limit = PHP_INT_MAX): array

Passing null gives this error:

Deprecated function: explode(): Passing null to parameter #2 ($string) of type string is deprecated...

Also, there is a type compatibility issue around \Drupal\views_streaming_data\StreamingViewExecutable::getIterator that requires \Traversable to be set as return type.

pwolanin’s picture

pwolanin commented
Status: Active » Needs review
pwolanin’s picture

pwolanin commented
StatusFileSize
new 3338660-4.patch1.86 KB
pwolanin’s picture

pwolanin commented
StatusFileSize
new 3338660-5.patch3.85 KB
pwolanin’s picture

pwolanin commented

This is failing on Drupal 10 due to issues with the csv_serialization module.

We need to either use the 3.x branch + this fix https://www.drupal.org/project/csv_serialization/issues/3294354

Or see that fixes are added to the 2.x branch and update our dependency to only that.

pwolanin’s picture

pwolanin commented
StatusFileSize
new 3338660-7.patch4.14 KB
pwolanin’s picture

pwolanin commented
StatusFileSize
new 3338660-8.patch4.14 KB

  • pwolanin committed 8673c30a on 8.x-1.x 
    Issue #3338660 by pwolanin, kdebisschop: PHP 8 and more Drupal 10 fixes
pwolanin’s picture

pwolanin commented
Status: Needs review » Fixed
kdebisschop’s picture

kdebisschop commented

patch in #8 looks good

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.