Problem/Motivation
These are security releases, but we don't use HttpCache so we're not directly affected. However, we should update anyway before doing this week's patch releases.
https://github.com/symfony/symfony/releases/tag/v6.2.6
https://github.com/symfony/symfony/releases/tag/v4.4.50
Steps to reproduce
Proposed resolution
Remaining tasks
User interface changes
API changes
Data model changes
Release notes snippet
| Comment | File | Size | Author |
|---|---|---|---|
| #7 | 3338301-7-9.4.x.patch | 54.24 KB | longwave |
| #2 | 3338301-10.1.x.patch | 38.53 KB | catch |
| #2 | 3338301-10.0.x.patch | 46.75 KB | catch |
| #2 | 3338301-9.5.x.patch | 6.46 KB | catch |
Comments
Comment #2
catchcomposer update symfony/*Only a couple of 9.5, several on 10.1.x and 10.0
If we really wanted to we could restrict the update just to the affected components, but if we get a green test run with everything, might as well be up-to-date IMO.
Comment #3
longwavePatches look good to me - RTBC assuming they all come back green. Agree that we might as well bump all Symfony components here to get the latest bug fixes; patch level updates are already allowed in core-recommended. The contracts packages do have a minor version bump in 10.0.x but I checked the diff on Symfony's side and it doesn't affect us at all, so this is fine too: https://github.com/symfony/contracts/compare/v3.1.1..v3.2.0
Comment #4
benjifisherDon't we need a patch for 9.4.x too? NW for that.
From the 10.0 patch:
I just want to point out that some of these are minor-version updates, not patch-level.
Comment #5
benjifisherSince this is not considered a security update, I guess it is up to the release managers whether to make a new release of 9.4. I think it is worth considering, in case there are 9.4 sites with custom or contrib code that uses the affected Symfony components.
Comment #6
longwave@benjifisher I noted the minor version bump in #3 - apart from docs and test-only changes, the only real code change is in the
SubscribedServiceattribute which we do not and cannot use yet in Drupal without significant work on the event system, so to me this is OK to bump.Comment #7
longwavePatch for 9.4.x. This bumps patch level dependencies of all Symfony components, plus minor version bumps of the PHP polyfills - again to me this is OK to do in a patch release, but happy to discuss if we think we should be more conservative.
Comment #8
jungleCOMPOSER_ROOT_VERSION=10.1.x-dev composer update symfony/* -vvv
COMPOSER_ROOT_VERSION=10.0.x-dev composer update symfony/* -vvv
COMPOSER_ROOT_VERSION=9.5.x-dev composer update symfony/* -vvv
COMPOSER_ROOT_VERSION=9.4.x-dev composer update symfony/* -vvv
Checked with the commands above against the corresponding branch, and the results are identical.
Comment #13
longwaveCommitted and pushed 6a9f48d093 to 10.1.x and f81b11ef9a to 10.0.x and 6d2bf8467a to 9.5.x and 10e6d00f94 to 9.4.x. Thanks!