Problem/Motivation

Drupal 10 is out, but this module isn't compatible yet.

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#5 Add-flag-10.png18.92 KByashingole
#5 Drupal-10-upgrade-status-95 (18).png27.27 KByashingole
#2 3338148-2.patch1.49 KBnoorulshameera

Issue fork flag_anon-3338148

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

Anybody created an issue. See original summary.

noorulshameera’s picture

noorulshameera commented
Status: Active » Needs review
StatusFileSize
new 3338148-2.patch1.49 KB

Adding patch to fix Drupal 10 compatibility issues.

Charchil Khandelwal made their first commit to this issue’s fork.

charchil khandelwal’s picture

charchil khandelwal commented

Patch #2 tested and successfully applied.

yashingole’s picture

yashingole commented
StatusFileSize
new Drupal-10-upgrade-status-95 (18).png27.27 KB
new Add-flag-10.png18.92 KB

I have reviewed and checked Patch #2 this works for drupal 9.4 and drupal 10.0. and 10.0.1
Screenshots of the compatibility on 9.4 and the Flag page on 10 have been attached for reference:

Grevil made their first commit to this issue’s fork.

Grevil opened merge request !3

grevil’s picture

grevil commented
Status: Needs review » Reviewed & tested by the community

RTBC +1!

I created an MR containing the changes by @noorulshameera for an easier review and auto fixed the remaining phpcs errors.

lonalore’s picture

lonalore
Primary language Hungarian
Location Budapest, Hungary
commented
Status: Reviewed & tested by the community » Needs work

@noorulshameera and @grevil

The new Once library was introduced in Drupal v9.2, this means that the module will no longer be compatible with Drupal 8, so please set the minimum version to 9.2:

core_version_requirement: ^9.2 || ^10

Thank you!

grevil’s picture

grevil commented

Right! My apologies!

grevil’s picture

grevil commented
Status: Needs work » Needs review
lonalore’s picture

lonalore
Primary language Hungarian
Location Budapest, Hungary
commented
Status: Needs review » Reviewed & tested by the community

Looks good to me! Thank you!

attheshow’s picture

attheshow commented

Thanks for the merge request/patch. If anyone needs a patch file from #10 for composer installation, it's at:
https://git.drupalcode.org/project/flag_anon/-/merge_requests/3.patch

  • noorulshameera authored c69bc590 on 8.x-1.x 
    Issue #3338148 by Grevil, Charchil Khandelwal, noorulshameera,...
antonnavi’s picture

antonnavi
Primary language Ukrainian
Location Leipzig
commented
Status: Reviewed & tested by the community » Fixed

Hello all here!

Thank you for help!

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented

Thank you all! I think @Grevil should also be credited for his fix and review.

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented

@noorulshameera, @Antonnavi are you planning to create a new release or should I?

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented

Nice, thanks! :)

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.