Problem/Motivation

Pages with a very large DOM may experience extremely poor performance.

Steps to reproduce

Load a diff on a page with 4000+ DOM elements. Observe the diff takes upwards of 30 seconds to crunch through.

Proposed resolution

Rearchitect the VisualInlineHtmlDiffLayout to not extend VisualInlineDiffLayout, but rather DiffLayoutBase instead. This should let half of the processing time be dropped.

API changes

No longer extending VisualInlineDiffLayout, but rather DiffLayoutBase.

Issue fork diff_plus-3336278

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

Luke.Leber created an issue. See original summary.

Luke.Leber opened merge request !7

luke.leber’s picture

luke.leber
Primary language English
Location Pennsylvania
commented
Status: Active » Fixed

  • Luke.Leber committed f0d80fe8 on 1.0.x 
    Issue #3336278 by Luke.Leber: Large pages perform poorly

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.