Problem/Motivation
A minor code comment mistake in NodeFieldAccessTest.php.
The text should be 'with revisions enabled', not 'disabled'.
Steps to reproduce
Check web/core/modules/node/tests/src/Kernel/NodeFieldAccessTest.php
// Create the article node type with revisions disabled. $article = NodeType::create([ 'type' => 'article', 'new_revision' => TRUE, ]); $article->save();
Proposed resolution
Correct the comment text.
Remaining tasks
Check and fix same issue in other versions.
User interface changes
API changes
Data model changes
Release notes snippet
Issue fork drupal-3334679
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
Comments
Comment #3
longwaveThanks - the original comment is wrong, the updated comment is correct.
Comment #7
xjmWith bugs like this, I always look at the context to make sure it's not more than just a typo. In this case, the lines just above are:
So it does look like a c/p mistake there
I checked later in the test to ensure the same mistake didn't recur:
So this is indeed a complete fix on its own, and is not hiding any other bugs.
Committed to 10.1.x, and cherry-picked to 10.0.x and 9.5.x. Thanks!